You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/22 09:21:44 UTC

[GitHub] [kafka] mimaison commented on pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

mimaison commented on pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#issuecomment-632591659


   Thanks @hachikuji for the feedback. You brought some interesting points that overall simplify the KIP/logic a bit. 
   While initially, it seemed a perfect use case for tagged fields, the need to bump the version to check for compatibility made it a bit confusing. 
   
   I've pushed an update following your suggestions to use a regular field and default to see all groups. I think it's easier to reason about and keeps the API simple. Let me know what you think. I'll update the KIP accordingly if we think that's the best option.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org