You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2017/02/15 11:47:01 UTC
[48/50] tinkerpop git commit: Introduce Revapi API checks into the
build.
Introduce Revapi API checks into the build.
The API checker is set up to only check classes in org.apache.tinkerpop
package (and sub packages) and is set up to ignore breaking changes
on a minor version increase.
It always reports non-public classes that leak into the API though.
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/f33235c2
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/f33235c2
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/f33235c2
Branch: refs/heads/TINKERPOP-1443
Commit: f33235c2ab239ee1e8b39cb77ae868544cb49c46
Parents: 2aa35f1
Author: Lukas Krejci <lk...@redhat.com>
Authored: Mon Nov 14 23:55:23 2016 +0100
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Wed Feb 15 06:45:05 2017 -0500
----------------------------------------------------------------------
gremlin-groovy-test/pom.xml | 3 +++
gremlin-python/pom.xml | 1 +
gremlin-test/pom.xml | 3 +++
pom.xml | 50 ++++++++++++++++++++++++++++++++++++++++
4 files changed, 57 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/f33235c2/gremlin-groovy-test/pom.xml
----------------------------------------------------------------------
diff --git a/gremlin-groovy-test/pom.xml b/gremlin-groovy-test/pom.xml
index 853b59f..fb98c00 100644
--- a/gremlin-groovy-test/pom.xml
+++ b/gremlin-groovy-test/pom.xml
@@ -25,6 +25,9 @@ limitations under the License.
</parent>
<artifactId>gremlin-groovy-test</artifactId>
<name>Apache TinkerPop :: Gremlin Groovy Test</name>
+ <properties>
+ <revapi.skip>true</revapi.skip>
+ </properties>
<dependencies>
<dependency>
<groupId>org.apache.tinkerpop</groupId>
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/f33235c2/gremlin-python/pom.xml
----------------------------------------------------------------------
diff --git a/gremlin-python/pom.xml b/gremlin-python/pom.xml
index 8935dfc..ad408ac 100644
--- a/gremlin-python/pom.xml
+++ b/gremlin-python/pom.xml
@@ -75,6 +75,7 @@
<maven.test.skip>false</maven.test.skip>
<skipTests>${maven.test.skip}</skipTests>
<gremlin.server.dir>${project.parent.basedir}/gremlin-server</gremlin.server.dir>
+ <revapi.skip>true</revapi.skip>
</properties>
<build>
<directory>${basedir}/target</directory>
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/f33235c2/gremlin-test/pom.xml
----------------------------------------------------------------------
diff --git a/gremlin-test/pom.xml b/gremlin-test/pom.xml
index f316188..6c8fdd2 100644
--- a/gremlin-test/pom.xml
+++ b/gremlin-test/pom.xml
@@ -25,6 +25,9 @@ limitations under the License.
</parent>
<artifactId>gremlin-test</artifactId>
<name>Apache TinkerPop :: Gremlin Test</name>
+ <properties>
+ <revapi.skip>true</revapi.skip>
+ </properties>
<dependencies>
<dependency>
<groupId>org.apache.tinkerpop</groupId>
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/f33235c2/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 8f6c922..87667fc 100644
--- a/pom.xml
+++ b/pom.xml
@@ -325,6 +325,56 @@ limitations under the License.
</dependency>
</dependencies>
</plugin>
+ <plugin>
+ <groupId>org.revapi</groupId>
+ <artifactId>revapi-maven-plugin</artifactId>
+ <version>0.7.0</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.revapi</groupId>
+ <artifactId>revapi-java</artifactId>
+ <version>0.11.2</version>
+ </dependency>
+ </dependencies>
+ <configuration>
+
+ <analysisConfiguration><![CDATA[
+ {
+ "revapi": {
+ "java": {
+ "filter": {
+ //gremlin-shaded includes a lot of stuff from 3rd party libraries that break their API between
+ //versions. Let's just not consider them part of Tinkerpop API. -->
+ "packages": {
+ "regex": true,
+ "exclude": ["org\\.apache\\.tinkerpop\\.shaded(\\..+)?"],
+ "include": ["org\\.apache\\.tinkerpop(\\..+)?"]
+ }
+ }
+ },
+ "semver": {
+ "ignore": {
+ "enabled": true,
+ "versionIncreaseAllows": {
+ "major": "breaking",
+ "minor": "breaking",
+ "patch": "nonBreaking"
+ },
+ "passThroughDifferences": ["java.class.nonPublicPartOfAPI"]
+ }
+ }
+ }
+ }
+ ]]></analysisConfiguration>
+ </configuration>
+ <executions>
+ <execution>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
<!-- we never use this plugin - disabling helps with speeding up other processing like when using -Dcoverage -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>