You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2025/05/07 08:07:27 UTC
[PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
amorynan opened a new pull request, #50656:
URL: https://github.com/apache/doris/pull/50656
### What problem does this PR solve?
fix support array_contains & arrays_overlap with array<ip> type
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #50656:
URL: https://github.com/apache/doris/pull/50656#issuecomment-2857519028
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50656:
URL: https://github.com/apache/doris/pull/50656#issuecomment-3488515182
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #50656:
URL: https://github.com/apache/doris/pull/50656#issuecomment-2858560720
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #50656: [fix](array-funcs) fix array_contains && arrays_overlap with ip
URL: https://github.com/apache/doris/pull/50656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50656:
URL: https://github.com/apache/doris/pull/50656#issuecomment-2857683347
<details>
<summary>TPC-DS: <b>Total hot run time: 185081 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 166ed566d25eb2ce0cf86bd456dfb3345deb98fd, data reload: false
query1 1016 484 517 484
query2 6566 1813 1810 1810
query3 6754 214 217 214
query4 26724 23493 22939 22939
query5 4317 620 481 481
query6 326 226 203 203
query7 4632 488 291 291
query8 305 270 255 255
query9 8618 2565 2606 2565
query10 488 316 277 277
query11 15919 15037 14760 14760
query12 166 109 100 100
query13 1639 505 397 397
query14 8983 6099 6039 6039
query15 212 179 173 173
query16 7186 644 458 458
query17 1183 709 555 555
query18 1957 397 296 296
query19 185 185 155 155
query20 116 113 113 113
query21 220 124 105 105
query22 4060 4202 4039 4039
query23 33760 32919 32984 32919
query24 8447 2381 2397 2381
query25 530 472 384 384
query26 1238 272 166 166
query27 2733 492 331 331
query28 4322 2073 2066 2066
query29 757 537 429 429
query30 279 217 186 186
query31 962 863 714 714
query32 73 65 68 65
query33 550 356 297 297
query34 802 842 508 508
query35 752 819 737 737
query36 962 1018 917 917
query37 112 98 80 80
query38 4089 4178 4151 4151
query39 1443 1418 1407 1407
query40 212 116 104 104
query41 58 56 53 53
query42 128 110 107 107
query43 501 510 474 474
query44 1307 788 790 788
query45 173 176 169 169
query46 820 1004 643 643
query47 1742 1800 1724 1724
query48 372 420 312 312
query49 782 512 429 429
query50 670 668 413 413
query51 4056 4124 4003 4003
query52 108 99 93 93
query53 217 246 180 180
query54 585 580 502 502
query55 81 81 80 80
query56 287 316 298 298
query57 1155 1153 1075 1075
query58 265 251 243 243
query59 2630 2726 2599 2599
query60 328 312 313 312
query61 128 131 128 128
query62 818 722 658 658
query63 223 198 194 194
query64 4423 997 667 667
query65 4297 4206 4273 4206
query66 1149 406 308 308
query67 15864 15434 15353 15353
query68 5303 868 516 516
query69 478 303 271 271
query70 1179 1137 1144 1137
query71 397 314 304 304
query72 5518 4718 4802 4718
query73 669 628 346 346
query74 9219 9173 8806 8806
query75 3201 3223 2677 2677
query76 3191 1168 761 761
query77 476 383 289 289
query78 9789 10014 9260 9260
query79 1850 803 567 567
query80 644 517 445 445
query81 500 255 214 214
query82 180 124 96 96
query83 259 253 237 237
query84 249 101 91 91
query85 751 396 310 310
query86 361 316 308 308
query87 4355 4319 4279 4279
query88 2810 2206 2199 2199
query89 389 335 285 285
query90 1848 212 211 211
query91 147 141 111 111
query92 76 60 59 59
query93 1526 922 585 585
query94 639 400 290 290
query95 367 287 287 287
query96 485 567 284 284
query97 3104 3210 3121 3121
query98 232 215 199 199
query99 1342 1424 1256 1256
Total cold run time: 268296 ms
Total hot run time: 185081 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #50656:
URL: https://github.com/apache/doris/pull/50656#issuecomment-2858559324
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50656:
URL: https://github.com/apache/doris/pull/50656#issuecomment-2857699182
<details>
<summary>ClickBench: <b>Total hot run time: 29.53 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 166ed566d25eb2ce0cf86bd456dfb3345deb98fd, data reload: false
query1 0.04 0.04 0.04
query2 0.12 0.11 0.11
query3 0.26 0.20 0.19
query4 1.60 0.20 0.18
query5 0.60 0.61 0.58
query6 1.19 0.71 0.73
query7 0.02 0.02 0.02
query8 0.04 0.03 0.04
query9 0.57 0.52 0.51
query10 0.57 0.57 0.58
query11 0.15 0.11 0.11
query12 0.15 0.11 0.12
query13 0.61 0.59 0.59
query14 0.79 0.80 0.80
query15 0.88 0.85 0.84
query16 0.37 0.36 0.37
query17 1.02 1.03 1.03
query18 0.21 0.20 0.20
query19 1.98 1.76 1.78
query20 0.02 0.02 0.01
query21 15.41 0.92 0.56
query22 0.76 1.26 0.60
query23 14.93 1.35 0.61
query24 6.49 2.17 1.28
query25 0.50 0.22 0.09
query26 0.60 0.15 0.14
query27 0.05 0.05 0.05
query28 11.05 0.79 0.43
query29 12.65 3.88 3.24
query30 0.25 0.09 0.07
query31 2.82 0.59 0.40
query32 3.22 0.55 0.46
query33 2.97 3.05 3.03
query34 15.80 5.06 4.53
query35 4.55 4.49 4.52
query36 0.66 0.51 0.48
query37 0.09 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.02 0.03
query40 0.16 0.13 0.14
query41 0.08 0.03 0.03
query42 0.03 0.03 0.02
query43 0.04 0.03 0.03
Total cold run time: 104.38 s
Total hot run time: 29.53 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50656:
URL: https://github.com/apache/doris/pull/50656#issuecomment-2857619733
<details>
<summary>TPC-H: <b>Total hot run time: 33823 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 166ed566d25eb2ce0cf86bd456dfb3345deb98fd, data reload: false
------ Round 1 ----------------------------------
q1 26462 4936 5030 4936
q2 2071 273 183 183
q3 10395 1259 706 706
q4 10234 1016 536 536
q5 7526 2398 2358 2358
q6 191 166 134 134
q7 921 767 622 622
q8 9336 1314 1086 1086
q9 6837 5126 5088 5088
q10 6814 2305 1898 1898
q11 483 290 279 279
q12 353 356 214 214
q13 17756 3662 3076 3076
q14 220 226 218 218
q15 546 488 488 488
q16 425 428 370 370
q17 598 862 375 375
q18 7579 7138 7051 7051
q19 1215 943 538 538
q20 336 359 225 225
q21 4158 2683 2470 2470
q22 1037 1007 972 972
Total cold run time: 115493 ms
Total hot run time: 33823 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5066 5041 5074 5041
q2 234 335 238 238
q3 2146 2678 2291 2291
q4 1374 1811 1324 1324
q5 4468 4539 4429 4429
q6 223 175 131 131
q7 2033 1939 1736 1736
q8 2602 2557 2573 2557
q9 7234 7121 7287 7121
q10 3045 3170 2706 2706
q11 581 516 490 490
q12 683 812 630 630
q13 3658 3900 3303 3303
q14 282 299 268 268
q15 529 498 468 468
q16 434 496 431 431
q17 1172 1591 1358 1358
q18 7695 7504 7320 7320
q19 860 861 925 861
q20 2008 2014 1871 1871
q21 5186 4633 4449 4449
q22 1036 1015 954 954
Total cold run time: 52549 ms
Total hot run time: 49977 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #50656:
URL: https://github.com/apache/doris/pull/50656#issuecomment-2858559023
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #50656:
URL: https://github.com/apache/doris/pull/50656#issuecomment-2857518848
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs) fix array_contains && arrays_overlap with ip [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50656:
URL: https://github.com/apache/doris/pull/50656#issuecomment-2857887012
# BE UT Coverage Report
Increment line coverage `6.25% (1/16)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/166ed566d25eb2ce0cf86bd456dfb3345deb98fd_166ed566d25eb2ce0cf86bd456dfb3345deb98fd/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/166ed566d25eb2ce0cf86bd456dfb3345deb98fd_166ed566d25eb2ce0cf86bd456dfb3345deb98fd/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.59% (14867/26744) |
| Line Coverage | 44.62% (131169/293948) |
| Region Coverage | 43.35% (66815/154143) |
| Branch Coverage | 37.93% (33715/88878) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org