[jira] [Commented] (IGNITE-5716) .NET: Negative field offset values can be observed on 2-byte offsets

["Pavel Tupitsyn (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077938#comment-16077938 ] 

Pavel Tupitsyn commented on IGNITE-5716:
----------------------------------------

Found another problem in {{BinaryReader.ReadSchema}}: {{ReadInt}} is always used for offsets, which is not correct.

> .NET: Negative field offset values can be observed on 2-byte offsets
> --------------------------------------------------------------------
>
>                 Key: IGNITE-5716
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5716
>             Project: Ignite
>          Issue Type: Bug
>          Components: platforms
>    Affects Versions: 1.9
>            Reporter: Pavel Tupitsyn
>            Assignee: Pavel Tupitsyn
>            Priority: Blocker
>              Labels: .NET
>             Fix For: 2.1
>
>
> {{BinaryObjectSchemaSerializer.WriteSchema}} uses {{ushort.MaxValue}} as a boundary for 2-byte offsets. {{ReadSchema}} uses {{ReadShort}}, which returns negative offsets for anything above {{short.MaxValue}}.
> * Ensure that all offsets are always non-negative (use uint in {{BinaryObjectSchemaField}} probably)
> * Check how Java handles this
> * Add tests for all edge cases



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)