You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2009/06/16 22:07:07 UTC
[jira] Created: (LUCENE-1699) Field tokenStream should be usable
with stored fields.
Field tokenStream should be usable with stored fields.
------------------------------------------------------
Key: LUCENE-1699
URL: https://issues.apache.org/jira/browse/LUCENE-1699
Project: Lucene - Java
Issue Type: Improvement
Reporter: Yonik Seeley
Priority: Minor
Fix For: 2.9
Field.tokenStream should be usable for indexing even for stored values. Useful for many types of pre-analyzed values (text/numbers, etc)
http://search.lucidimagination.com/search/document/902bad4eae20bdb8/field_tokenstreamvalue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1699) Field tokenStream should be usable
with stored fields.
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated LUCENE-1699:
---------------------------------
Attachment: LUCENE-1699.patch
incomplete patch for feedback - needs tests and further work to allow binary field values with token streams (I assume this would be desirable for numeric fields).
> Field tokenStream should be usable with stored fields.
> ------------------------------------------------------
>
> Key: LUCENE-1699
> URL: https://issues.apache.org/jira/browse/LUCENE-1699
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1699.patch
>
>
> Field.tokenStream should be usable for indexing even for stored values. Useful for many types of pre-analyzed values (text/numbers, etc)
> http://search.lucidimagination.com/search/document/902bad4eae20bdb8/field_tokenstreamvalue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1699) Field tokenStream should be usable
with stored fields.
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved LUCENE-1699.
----------------------------------
Resolution: Fixed
committed.
> Field tokenStream should be usable with stored fields.
> ------------------------------------------------------
>
> Key: LUCENE-1699
> URL: https://issues.apache.org/jira/browse/LUCENE-1699
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1699.patch, LUCENE-1699.patch
>
>
> Field.tokenStream should be usable for indexing even for stored values. Useful for many types of pre-analyzed values (text/numbers, etc)
> http://search.lucidimagination.com/search/document/902bad4eae20bdb8/field_tokenstreamvalue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1699) Field tokenStream should be usable
with stored fields.
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720352#action_12720352 ]
Yonik Seeley commented on LUCENE-1699:
--------------------------------------
Watch out - there's a new sheriff in town!
> Field tokenStream should be usable with stored fields.
> ------------------------------------------------------
>
> Key: LUCENE-1699
> URL: https://issues.apache.org/jira/browse/LUCENE-1699
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1699.patch
>
>
> Field.tokenStream should be usable for indexing even for stored values. Useful for many types of pre-analyzed values (text/numbers, etc)
> http://search.lucidimagination.com/search/document/902bad4eae20bdb8/field_tokenstreamvalue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1699) Field tokenStream should be usable
with stored fields.
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720353#action_12720353 ]
Mark Miller commented on LUCENE-1699:
-------------------------------------
This group could develop hard for the rest of the year no problem by the looks. Someones got to herd these cats. Since we last semi decided it would be a good idea to release 2.9, we have rewritten half the core code base :)
> Field tokenStream should be usable with stored fields.
> ------------------------------------------------------
>
> Key: LUCENE-1699
> URL: https://issues.apache.org/jira/browse/LUCENE-1699
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1699.patch
>
>
> Field.tokenStream should be usable for indexing even for stored values. Useful for many types of pre-analyzed values (text/numbers, etc)
> http://search.lucidimagination.com/search/document/902bad4eae20bdb8/field_tokenstreamvalue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1699) Field tokenStream should be usable
with stored fields.
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller reassigned LUCENE-1699:
-----------------------------------
Assignee: Yonik Seeley
Another 2.9 huh? You own it then :)
> Field tokenStream should be usable with stored fields.
> ------------------------------------------------------
>
> Key: LUCENE-1699
> URL: https://issues.apache.org/jira/browse/LUCENE-1699
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1699.patch
>
>
> Field.tokenStream should be usable for indexing even for stored values. Useful for many types of pre-analyzed values (text/numbers, etc)
> http://search.lucidimagination.com/search/document/902bad4eae20bdb8/field_tokenstreamvalue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1699) Field tokenStream should be usable
with stored fields.
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720578#action_12720578 ]
Michael McCandless commented on LUCENE-1699:
--------------------------------------------
Patch looks good:
* Can you make sure CHANGES describes this new behavior (Field is
allowed to have both a tokenStream and a String/Reader/binary
value)?
* The javadoc for readerValue is wrong (copy/paste from stringValue)
* Can you spell out more clearly in the javadocs that even when a
tokenStream value is set, one of String/Reader/binary may also be
set, or, not, and if so, that "other" value is only used for
stored fields. Eg, explain why one would use setTokenStream
instead of setValue(TokenStream value).
> Field tokenStream should be usable with stored fields.
> ------------------------------------------------------
>
> Key: LUCENE-1699
> URL: https://issues.apache.org/jira/browse/LUCENE-1699
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1699.patch
>
>
> Field.tokenStream should be usable for indexing even for stored values. Useful for many types of pre-analyzed values (text/numbers, etc)
> http://search.lucidimagination.com/search/document/902bad4eae20bdb8/field_tokenstreamvalue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1699) Field tokenStream should be usable
with stored fields.
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated LUCENE-1699:
---------------------------------
Attachment: LUCENE-1699.patch
Patch attached.
I've attempted to clean up some of the semantics of Fieldable - it's really a reasonable interface, with just a few redundancies (isBinary/getBinary). I've purposely avoided messing with Field more than necessary (adding yet more constructors, constants, etc).
This change is back compatible as it just removes some unnecessary restrictions. I'll commit in a few days.
> Field tokenStream should be usable with stored fields.
> ------------------------------------------------------
>
> Key: LUCENE-1699
> URL: https://issues.apache.org/jira/browse/LUCENE-1699
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1699.patch, LUCENE-1699.patch
>
>
> Field.tokenStream should be usable for indexing even for stored values. Useful for many types of pre-analyzed values (text/numbers, etc)
> http://search.lucidimagination.com/search/document/902bad4eae20bdb8/field_tokenstreamvalue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org