You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2018/11/07 00:14:34 UTC

[GitHub] [geode] kirklund opened pull request #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

1) GEODE-5997: Create FastLogger benchmarks
New JMH Benchmarks for FastLogger and Log4j2 Logger. Also includes comparisons of different approaches for parameters.

2) GEODE-5997: Delete old logging performance tests

3) GEODE-5997: Override ExtendedLogger methods in FastLogger
This allows us to retain the performance improvements of FastLogger and remove isDebugEnabled and isTraceEnabled guard clauses from logger debug and trace log statements.

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Below are the results of running FastLoggerBenchmark and FastLoggerParamsBenchmark with the configured settings (which are pretty short). This is showing number of ops (log statements) per second. The enabled log level is INFO so the debug benchmarks are showing the number of disabled log statements per second, while the info benchmarks are showing the number of enabled log statements.
```
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1140378568.819          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        581609863.899          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        983969575.450          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        494294798.393          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4987321.584          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4732322.932          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5567982.935          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5394038.341          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1201945194.555          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        590098348.351          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5639765.772          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5591034.845          ops/s

Benchmark                                                                                 Mode  Cnt           Score   Error  Units
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1116586797.172          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1104963621.430          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            63208.760          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72440052.162          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        633102739.342          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         32081069.921          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         94661455.407          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        644039662.975          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            59992.915          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4149139.617          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            63423.394          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3124434.749          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4087878.093          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4604518.440          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3582505.282          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4444080.268          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1142947889.813          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1160009470.068          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1141453898.578          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1118099749.331          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1145103424.363          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1065989332.803          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61046.349          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          4317317.300          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            60507.705          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3293374.913          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4358819.938          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4616290.646          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3596479.899          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4094615.116          ops/s
FasterLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        556933807.539          ops/s
FasterLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        572523916.059          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            57321.294          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         83977910.327          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        486608883.220          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         34533973.260          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         76632932.576          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        466369919.883          ops/s
FasterLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            61555.953          ops/s
FasterLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4193241.593          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61853.767          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2883375.456          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4058161.684          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          3938143.663          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3669863.702          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4390586.627          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        515321848.206          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        589155764.117          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        587837022.387          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        561898955.072          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        577965496.685          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        589392041.676          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            61586.162          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          3977824.119          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            58787.252          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          2995286.904          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4130394.631          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4584411.374          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3669342.646          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4396702.939          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods. Below are the updated benchmarks for the updated new FastLogger.
```
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5434742.791          ops/s

Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1104597250.736          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1122079356.538          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            62310.745          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt        108372718.742          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        640088685.271          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         33563974.004          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt        111465798.604          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        587042790.986          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            63439.069          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4015675.240          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            65725.975          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          2862554.390          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          3936138.634          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4814081.811          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3204967.544          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4069304.294          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1518298057.954          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1602842159.965          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1628595413.479          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1680373236.675          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1651172611.005          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1610583827.546          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61428.865          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3852665.858          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            58609.440          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3158028.484          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4102848.671          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4839929.223          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3338730.461          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4201726.612          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        531518403.530          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        569691161.395          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            59075.714          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         98338153.479          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        474294177.494          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         31814970.139          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         90557455.938          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        463374178.966          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            63323.215          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4102774.250          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61332.958          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2963537.103          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4316426.530          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4497256.214          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3587299.540          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4405537.186          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        574936995.598          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        580272606.519          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        572347282.489          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        579790689.279          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        578053774.992          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        565843868.108          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            62635.062          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4035621.514          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61300.871          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3291116.046          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4319667.962          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4541614.959          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3291020.991          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4124760.341          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.

the expression (level.intLevel() > DEFAULT_LEVEL.intLevel() && !delegating) is reused many times. Consider refactoring it into a private method.

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.

Also it is not clear to me that DEFAULT_LEVEL is a win over Level.INFO which is also a constant. If it could refer to the place that actually defines the default level then it would be a clear win.

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

@metatype The new FastLogger outperforms the vanilla Log4j Logger and the old FastLogger in every way EXCEPT for log statements that are enclosed within isDebugEnabled  and isInfoEnabled. Since we don't use isInfoEnabled, we're really only concerned about the difference in performance for isDebugEnabled.

Here's the numbers that are concerning:
```
Old FastLogger (rerun)
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1699492309.718          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        569546071.809          ops/s
```
```
New FastLogger (rerun with updated changes)
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
```
And here's one more run of New FastLogger just to demonstrate variance from run-to-run:
```
New FastLogger (rerun again with updated changes)
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1647331591.312          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        577427794.141          ops/s
```
It comes close to old FastLogger but can't quite catch up on this one. It is interesting to see vanilla Logger get one run that slightly faster than old FastLogger though.

To really be sure, I think I'd have to run the benchmarks for several longer iterations (overnight). Then we can be more confident of the numbers we're seeing.

I should also point out that wrapping logger.debug statements inside isDebugEnabled guard clauses always outperforms logger.debug by itself for vanilla Logger, old FastLogger and new FastLogger. So as much as folks want to be able to remove those guard clauses, I think we may be stuck with them for performance reasons.

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Anil and I determined that the overridden isDebugEnabled and isTraceEnabled methods should be restored because those are still used throughout the code base and we need their performance to be maintained.

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods. Below are the updated benchmarks for the updated new FastLogger.
```
Old FastLogger (rerun)

Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt        446697742.457          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        565131236.886          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        401641232.494          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        485306907.748          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4326126.623          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4292089.465          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5763926.454          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5310548.197          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1699492309.718          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        569546071.809          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5457045.502          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5495846.664          ops/s

Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt        451876778.653          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt        451070580.281          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            59405.794          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72445029.895          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        380674234.153          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         32968051.850          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         82931286.118          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        374891790.571          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            62344.822          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          3976585.123          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            62340.266          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3222964.423          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4158973.043          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4859433.590          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3692724.243          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          3992867.716          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1665159502.335          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1669136966.301          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1543797823.648          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1704361349.064          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1702927638.718          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1681265088.036          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            63659.776          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          4092671.778          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            63116.176          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3168981.597          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4344941.709          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4906448.447          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3310396.647          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4273380.437          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        576560073.265          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        557746928.981          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            62126.247          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         86528327.705          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        476592760.324          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         32544589.923          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         94132772.202          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        482992051.719          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            62085.698          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4277359.399          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            60765.569          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          3071808.366          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          3955382.527          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4768147.428          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3663289.372          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4165189.038          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        589802307.629          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        591908605.738          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        581341989.896          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        580041638.285          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        576919470.597          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        589862980.782          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            60934.166          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4007549.878          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61696.077          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3139579.662          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4323285.820          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4902451.680          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3382029.524          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          3812427.515          ops/s
```
```
New FastLogger (rerun with updated changes)

Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5434742.791          ops/s

Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1104597250.736          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1122079356.538          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            62310.745          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt        108372718.742          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        640088685.271          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         33563974.004          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt        111465798.604          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        587042790.986          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            63439.069          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4015675.240          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            65725.975          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          2862554.390          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          3936138.634          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4814081.811          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3204967.544          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4069304.294          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1518298057.954          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1602842159.965          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1628595413.479          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1680373236.675          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1651172611.005          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1610583827.546          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61428.865          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3852665.858          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            58609.440          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3158028.484          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4102848.671          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4839929.223          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3338730.461          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4201726.612          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        531518403.530          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        569691161.395          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            59075.714          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         98338153.479          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        474294177.494          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         31814970.139          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         90557455.938          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        463374178.966          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            63323.215          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4102774.250          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61332.958          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2963537.103          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4316426.530          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4497256.214          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3587299.540          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4405537.186          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        574936995.598          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        580272606.519          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        572347282.489          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        579790689.279          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        578053774.992          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        565843868.108          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            62635.062          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4035621.514          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61300.871          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3291116.046          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4319667.962          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4541614.959          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3291020.991          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4124760.341          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods.
```
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5434742.791          ops/s

Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1104597250.736          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1122079356.538          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            62310.745          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt        108372718.742          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        640088685.271          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         33563974.004          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt        111465798.604          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        587042790.986          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            63439.069          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4015675.240          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            65725.975          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          2862554.390          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          3936138.634          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4814081.811          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3204967.544          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4069304.294          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1518298057.954          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1602842159.965          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1628595413.479          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1680373236.675          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1651172611.005          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1610583827.546          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61428.865          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3852665.858          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            58609.440          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3158028.484          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4102848.671          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4839929.223          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3338730.461          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4201726.612          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        531518403.530          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        569691161.395          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            59075.714          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         98338153.479          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        474294177.494          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         31814970.139          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         90557455.938          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        463374178.966          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            63323.215          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4102774.250          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61332.958          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2963537.103          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4316426.530          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4497256.214          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3587299.540          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4405537.186          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        574936995.598          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        580272606.519          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        572347282.489          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        579790689.279          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        578053774.992          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        565843868.108          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            62635.062          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4035621.514          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61300.871          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3291116.046          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4319667.962          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4541614.959          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3291020.991          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4124760.341          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods. Below are the updated benchmarks for the updated new FastLogger.
```
Old FastLogger (rerun)
--pending--
Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt        451876778.653          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt        451070580.281          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            59405.794          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72445029.895          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        380674234.153          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         32968051.850          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         82931286.118          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        374891790.571          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            62344.822          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          3976585.123          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            62340.266          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3222964.423          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4158973.043          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4859433.590          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3692724.243          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          3992867.716          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1665159502.335          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1669136966.301          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1543797823.648          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1704361349.064          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1702927638.718          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1681265088.036          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            63659.776          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          4092671.778          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            63116.176          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3168981.597          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4344941.709          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4906448.447          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3310396.647          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4273380.437          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        576560073.265          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        557746928.981          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            62126.247          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         86528327.705          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        476592760.324          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         32544589.923          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         94132772.202          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        482992051.719          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            62085.698          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4277359.399          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            60765.569          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          3071808.366          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          3955382.527          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4768147.428          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3663289.372          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4165189.038          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        589802307.629          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        591908605.738          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        581341989.896          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        580041638.285          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        576919470.597          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        589862980.782          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            60934.166          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4007549.878          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61696.077          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3139579.662          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4323285.820          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4902451.680          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3382029.524          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          3812427.515          ops/s
```
```
New FastLogger (rerun with updated changes)
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5434742.791          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1104597250.736          ops/s

Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1122079356.538          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            62310.745          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt        108372718.742          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        640088685.271          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         33563974.004          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt        111465798.604          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        587042790.986          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            63439.069          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4015675.240          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            65725.975          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          2862554.390          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          3936138.634          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4814081.811          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3204967.544          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4069304.294          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1518298057.954          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1602842159.965          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1628595413.479          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1680373236.675          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1651172611.005          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1610583827.546          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61428.865          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3852665.858          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            58609.440          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3158028.484          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4102848.671          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4839929.223          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3338730.461          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4201726.612          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        531518403.530          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        569691161.395          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            59075.714          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         98338153.479          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        474294177.494          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         31814970.139          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         90557455.938          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        463374178.966          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            63323.215          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4102774.250          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61332.958          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2963537.103          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4316426.530          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4497256.214          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3587299.540          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4405537.186          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        574936995.598          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        580272606.519          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        572347282.489          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        579790689.279          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        578053774.992          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        565843868.108          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            62635.062          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4035621.514          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61300.871          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3291116.046          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4319667.962          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4541614.959          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3291020.991          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4124760.341          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods. Below are the updated benchmarks for the updated new FastLogger.
```
Old FastLogger (rerun)

Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt        446697742.457          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        565131236.886          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        401641232.494          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        485306907.748          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4326126.623          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4292089.465          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5763926.454          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5310548.197          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1699492309.718          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        569546071.809          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5457045.502          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5495846.664          ops/s

Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt        451876778.653          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt        451070580.281          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            59405.794          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72445029.895          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        380674234.153          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         32968051.850          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         82931286.118          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        374891790.571          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            62344.822          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          3976585.123          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            62340.266          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3222964.423          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4158973.043          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4859433.590          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3692724.243          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          3992867.716          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1665159502.335          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1669136966.301          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1543797823.648          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1704361349.064          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1702927638.718          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1681265088.036          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            63659.776          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          4092671.778          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            63116.176          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3168981.597          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4344941.709          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4906448.447          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3310396.647          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4273380.437          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        576560073.265          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        557746928.981          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            62126.247          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         86528327.705          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        476592760.324          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         32544589.923          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         94132772.202          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        482992051.719          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            62085.698          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4277359.399          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            60765.569          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          3071808.366          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          3955382.527          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4768147.428          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3663289.372          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4165189.038          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        589802307.629          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        591908605.738          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        581341989.896          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        580041638.285          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        576919470.597          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        589862980.782          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            60934.166          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4007549.878          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61696.077          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3139579.662          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4323285.820          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4902451.680          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3382029.524          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          3812427.515          ops/s
```
```
New FastLogger (rerun with updated changes)

Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5434742.791          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1104597250.736          ops/s

Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1122079356.538          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            62310.745          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt        108372718.742          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        640088685.271          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         33563974.004          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt        111465798.604          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        587042790.986          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            63439.069          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4015675.240          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            65725.975          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          2862554.390          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          3936138.634          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4814081.811          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3204967.544          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4069304.294          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1518298057.954          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1602842159.965          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1628595413.479          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1680373236.675          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1651172611.005          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1610583827.546          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61428.865          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3852665.858          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            58609.440          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3158028.484          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4102848.671          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4839929.223          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3338730.461          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4201726.612          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        531518403.530          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        569691161.395          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            59075.714          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         98338153.479          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        474294177.494          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         31814970.139          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         90557455.938          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        463374178.966          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            63323.215          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4102774.250          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61332.958          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2963537.103          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4316426.530          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4497256.214          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3587299.540          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4405537.186          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        574936995.598          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        580272606.519          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        572347282.489          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        579790689.279          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        578053774.992          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        565843868.108          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            62635.062          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4035621.514          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61300.871          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3291116.046          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4319667.962          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4541614.959          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3291020.991          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4124760.341          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods. Below are the updated benchmarks for the updated new FastLogger.
```
Old FastLogger (rerun)

Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt        446697742.457          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        565131236.886          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        401641232.494          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        485306907.748          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4326126.623          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4292089.465          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5763926.454          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5310548.197          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1699492309.718          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        569546071.809          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5457045.502          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5495846.664          ops/s
```
```
New FastLogger (rerun with updated changes)

Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5434742.791          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods. Below are the updated benchmarks for the updated new FastLogger.
```
Old FastLogger (rerun without changes)
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5434742.791          ops/s

New FastLogger (rerun with updated changes)
Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1104597250.736          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1122079356.538          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            62310.745          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt        108372718.742          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        640088685.271          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         33563974.004          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt        111465798.604          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        587042790.986          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            63439.069          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4015675.240          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            65725.975          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          2862554.390          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          3936138.634          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4814081.811          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3204967.544          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4069304.294          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1518298057.954          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1602842159.965          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1628595413.479          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1680373236.675          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1651172611.005          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1610583827.546          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61428.865          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3852665.858          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            58609.440          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3158028.484          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4102848.671          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4839929.223          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3338730.461          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4201726.612          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        531518403.530          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        569691161.395          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            59075.714          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         98338153.479          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        474294177.494          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         31814970.139          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         90557455.938          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        463374178.966          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            63323.215          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4102774.250          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61332.958          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2963537.103          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4316426.530          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4497256.214          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3587299.540          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4405537.186          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        574936995.598          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        580272606.519          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        572347282.489          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        579790689.279          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        578053774.992          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        565843868.108          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            62635.062          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4035621.514          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61300.871          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3291116.046          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4319667.962          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4541614.959          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3291020.991          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4124760.341          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Here are the results of the benchmarks for the existing version of Fast Logger (Old FastLogger) and the new version.
```
Old FastLogger
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt        452589817.298          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        422116832.994          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4343709.227          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5704628.652          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1658914321.955          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5476225.160          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt        461554581.394          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt        454982464.671          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            54922.374          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72270771.571          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        395315939.389          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         31729255.931          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         75003948.589          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        398282736.583          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            60781.948          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4266203.185          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            61517.512          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3270640.360          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4336635.530          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          5060276.652          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3576160.300          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4472861.009          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1775327393.589          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1771391951.370          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1697242021.614          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1700169949.156          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1751201629.657          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1681672663.338          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            67020.481          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3863578.293          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            60506.000          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3153923.623          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4540061.799          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          5232540.934          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3392897.809          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4333777.388          ops/s

New FastLogger
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1140378568.819          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        983969575.450          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4987321.584          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5567982.935          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1201945194.555          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5639765.772          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1116586797.172          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1104963621.430          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            63208.760          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72440052.162          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        633102739.342          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         32081069.921          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         94661455.407          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        644039662.975          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            59992.915          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4149139.617          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            63423.394          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3124434.749          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4087878.093          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4604518.440          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3582505.282          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4444080.268          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1142947889.813          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1160009470.068          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1141453898.578          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1118099749.331          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1145103424.363          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1065989332.803          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61046.349          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          4317317.300          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            60507.705          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3293374.913          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4358819.938          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4616290.646          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3596479.899          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4094615.116          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "metatype (GitHub)" <gi...@apache.org>.

I just looked at `fastLoggerIsInfoEnabledLogStatementWithParams` and it seems like the old FastLogger is faster than the new version?  Am I reading that correctly?

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods. Below are the updated benchmarks for the updated new FastLogger.
```
Old FastLogger (rerun)
--pending--

New FastLogger (rerun with updated changes)
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5434742.791          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1104597250.736          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1122079356.538          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            62310.745          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt        108372718.742          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        640088685.271          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         33563974.004          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt        111465798.604          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        587042790.986          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            63439.069          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4015675.240          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            65725.975          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          2862554.390          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          3936138.634          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4814081.811          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3204967.544          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4069304.294          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1518298057.954          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1602842159.965          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1628595413.479          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1680373236.675          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1651172611.005          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1610583827.546          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61428.865          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3852665.858          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            58609.440          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3158028.484          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4102848.671          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4839929.223          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3338730.461          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4201726.612          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        531518403.530          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        569691161.395          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            59075.714          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         98338153.479          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        474294177.494          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         31814970.139          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         90557455.938          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        463374178.966          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            63323.215          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4102774.250          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61332.958          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2963537.103          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4316426.530          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4497256.214          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3587299.540          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4405537.186          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        574936995.598          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        580272606.519          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        572347282.489          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        579790689.279          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        578053774.992          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        565843868.108          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            62635.062          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4035621.514          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61300.871          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3291116.046          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4319667.962          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4541614.959          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3291020.991          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4124760.341          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Here are the results of the benchmarks for the existing version of Fast Logger (Old FastLogger) and the new version. The new version seems to consistently out-perform the old version.
```
Old FastLogger
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt        452589817.298          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        422116832.994          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4343709.227          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5704628.652          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1658914321.955          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5476225.160          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt        461554581.394          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt        454982464.671          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            54922.374          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72270771.571          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        395315939.389          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         31729255.931          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         75003948.589          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        398282736.583          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            60781.948          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4266203.185          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            61517.512          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3270640.360          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4336635.530          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          5060276.652          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3576160.300          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4472861.009          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1775327393.589          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1771391951.370          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1697242021.614          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1700169949.156          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1751201629.657          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1681672663.338          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            67020.481          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3863578.293          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            60506.000          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3153923.623          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4540061.799          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          5232540.934          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3392897.809          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4333777.388          ops/s

New FastLogger
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1140378568.819          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        983969575.450          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4987321.584          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5567982.935          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1201945194.555          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5639765.772          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1116586797.172          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1104963621.430          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            63208.760          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72440052.162          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        633102739.342          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         32081069.921          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         94661455.407          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        644039662.975          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            59992.915          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4149139.617          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            63423.394          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3124434.749          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4087878.093          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4604518.440          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3582505.282          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4444080.268          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1142947889.813          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1160009470.068          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1141453898.578          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1118099749.331          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1145103424.363          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1065989332.803          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61046.349          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          4317317.300          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            60507.705          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3293374.913          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4358819.938          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4616290.646          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3596479.899          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4094615.116          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods. Below are the updated benchmarks for the updated new FastLogger.
```
Old FastLogger (rerun)
--pending--
Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt        451876778.653          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt        451070580.281          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            59405.794          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72445029.895          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        380674234.153          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         32968051.850          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         82931286.118          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        374891790.571          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            62344.822          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          3976585.123          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            62340.266          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3222964.423          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4158973.043          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4859433.590          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3692724.243          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          3992867.716          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1665159502.335          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1669136966.301          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1543797823.648          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1704361349.064          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1702927638.718          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1681265088.036          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            63659.776          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          4092671.778          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            63116.176          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3168981.597          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4344941.709          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4906448.447          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3310396.647          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4273380.437          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        576560073.265          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        557746928.981          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            62126.247          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         86528327.705          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        476592760.324          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         32544589.923          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         94132772.202          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        482992051.719          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            62085.698          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4277359.399          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            60765.569          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          3071808.366          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          3955382.527          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4768147.428          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3663289.372          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4165189.038          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        589802307.629          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        591908605.738          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        581341989.896          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        580041638.285          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        576919470.597          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        589862980.782          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            60934.166          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4007549.878          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61696.077          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3139579.662          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4323285.820          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4902451.680          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3382029.524          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          3812427.515          ops/s

New FastLogger (rerun with updated changes)
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5434742.791          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1104597250.736          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1122079356.538          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            62310.745          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt        108372718.742          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        640088685.271          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         33563974.004          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt        111465798.604          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        587042790.986          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            63439.069          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4015675.240          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            65725.975          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          2862554.390          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          3936138.634          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4814081.811          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3204967.544          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4069304.294          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1518298057.954          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1602842159.965          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1628595413.479          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1680373236.675          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1651172611.005          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1610583827.546          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61428.865          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3852665.858          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            58609.440          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3158028.484          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4102848.671          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4839929.223          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3338730.461          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4201726.612          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        531518403.530          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        569691161.395          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            59075.714          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         98338153.479          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        474294177.494          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         31814970.139          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         90557455.938          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        463374178.966          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            63323.215          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4102774.250          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61332.958          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2963537.103          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4316426.530          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4497256.214          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3587299.540          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4405537.186          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        574936995.598          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        580272606.519          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        572347282.489          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        579790689.279          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        578053774.992          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        565843868.108          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            62635.062          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4035621.514          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61300.871          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3291116.046          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4319667.962          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4541614.959          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3291020.991          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4124760.341          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

I made the changes Darrel requested, removed the overridden logMessage because it breaks the contract for that method, and restored the overridden isDebugEnabled/isTraceEnabled methods.

Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1098409906.287          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        571517818.578          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        961929444.019          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        493419877.521          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4880988.472          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4359830.282          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5871701.712          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5413616.788          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5418763.689          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5434742.791          ops/s

Benchmark                                                                               Mode  Cnt           Score   Error  Units
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1104597250.736          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1122079356.538          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            62310.745          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt        108372718.742          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        640088685.271          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         33563974.004          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt        111465798.604          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        587042790.986          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            63439.069          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4015675.240          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            65725.975          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          2862554.390          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          3936138.634          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4814081.811          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3204967.544          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4069304.294          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1518298057.954          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1602842159.965          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1628595413.479          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1680373236.675          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1651172611.005          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1610583827.546          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61428.865          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3852665.858          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            58609.440          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3158028.484          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4102848.671          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4839929.223          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3338730.461          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4201726.612          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        531518403.530          ops/s
FastLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        569691161.395          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            59075.714          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         98338153.479          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        474294177.494          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         31814970.139          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         90557455.938          ops/s
FastLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        463374178.966          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            63323.215          ops/s
FastLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4102774.250          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61332.958          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2963537.103          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4316426.530          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          4497256.214          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3587299.540          ops/s
FastLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4405537.186          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        574936995.598          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        580272606.519          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        572347282.489          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        579790689.279          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        578053774.992          ops/s
FastLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        565843868.108          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            62635.062          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          4035621.514          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            61300.871          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          3291116.046          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4319667.962          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4541614.959          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3291020.991          ops/s
FastLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4124760.341          ops/s


[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

@metatype The new FastLogger outperforms the vanilla Log4j Logger and the old FastLogger in every way EXCEPT for log statements that are enclosed within isDebugEnabled  and isInfoEnabled. Since we don't use isInfoEnabled, we're really only concerned about the difference in performance for isDebugEnabled which does outperform any debug logger statements without using isDebugEnabled.

Here's the numbers that are concerning:
```
Old FastLogger (rerun)
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1699492309.718          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        569546071.809          ops/s
```
```
New FastLogger (rerun with updated changes)
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
```
And here's one more run of New FastLogger just to demonstrate variance from run-to-run:
```
New FastLogger (rerun again with updated changes)
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1647331591.312          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        577427794.141          ops/s
```
It comes close to old FastLogger but can't quite catch up on this one. It is interesting to see vanilla Logger get one run that slightly faster than old FastLogger though.

To really be sure, I think I'd have to run the benchmarks for several longer iterations (overnight). Then we can be more confident of the numbers we're seeing.

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Below are the results of running FastLoggerBenchmark and FastLoggerParamsBenchmark with the configured settings (which are pretty short). This is showing number of operations (log statements) per second. The enabled log level is INFO so the debug benchmarks are showing the number of disabled log statements per second, while the info benchmarks are showing the number of enabled log statements.
```
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1140378568.819          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        581609863.899          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        983969575.450          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        494294798.393          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4987321.584          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4732322.932          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5567982.935          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5394038.341          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1201945194.555          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        590098348.351          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5639765.772          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5591034.845          ops/s

Benchmark                                                                                 Mode  Cnt           Score   Error  Units
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1116586797.172          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1104963621.430          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            63208.760          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72440052.162          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        633102739.342          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         32081069.921          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         94661455.407          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        644039662.975          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            59992.915          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4149139.617          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            63423.394          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3124434.749          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4087878.093          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4604518.440          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3582505.282          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4444080.268          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1142947889.813          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1160009470.068          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1141453898.578          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1118099749.331          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1145103424.363          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1065989332.803          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61046.349          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          4317317.300          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            60507.705          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3293374.913          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4358819.938          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4616290.646          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3596479.899          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4094615.116          ops/s
FasterLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        556933807.539          ops/s
FasterLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        572523916.059          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            57321.294          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         83977910.327          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        486608883.220          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         34533973.260          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         76632932.576          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        466369919.883          ops/s
FasterLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            61555.953          ops/s
FasterLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4193241.593          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61853.767          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2883375.456          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4058161.684          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          3938143.663          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3669863.702          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4390586.627          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        515321848.206          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        589155764.117          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        587837022.387          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        561898955.072          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        577965496.685          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        589392041.676          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            61586.162          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          3977824.119          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            58787.252          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          2995286.904          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4130394.631          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4584411.374          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3669342.646          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4396702.939          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Here are the results of the benchmarks for the existing version of Fast Logger (Old FastLogger) and the new version.
```
Old FastLogger
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt        452589817.298          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        422116832.994          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4343709.227          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5704628.652          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1658914321.955          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5476225.160          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt        461554581.394          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt        454982464.671          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            54922.374          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72270771.571          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        395315939.389          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         31729255.931          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         75003948.589          ops/s
FastLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        398282736.583          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            60781.948          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4266203.185          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            61517.512          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3270640.360          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4336635.530          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          5060276.652          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3576160.300          ops/s
FastLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4472861.009          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1775327393.589          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1771391951.370          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1697242021.614          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1700169949.156          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1751201629.657          ops/s
FastLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1681672663.338          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            67020.481          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          3863578.293          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            60506.000          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3153923.623          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4540061.799          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          5232540.934          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3392897.809          ops/s
FastLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4333777.388          ops/s

New FastLogger
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1140378568.819          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        983969575.450          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4987321.584          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5567982.935          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1201945194.555          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5639765.772          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1116586797.172          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1104963621.430          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            63208.760          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72440052.162          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        633102739.342          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         32081069.921          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         94661455.407          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        644039662.975          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            59992.915          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4149139.617          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            63423.394          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3124434.749          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4087878.093          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4604518.440          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3582505.282          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4444080.268          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1142947889.813          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1160009470.068          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1141453898.578          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1118099749.331          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1145103424.363          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1065989332.803          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61046.349          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          4317317.300          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            60507.705          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3293374.913          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4358819.938          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4616290.646          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3596479.899          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4094615.116          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

@metatype The new FastLogger outperforms the vanilla Log4j Logger and the old FastLogger in every way EXCEPT for log statements that are enclosed within isDebugEnabled  and isInfoEnabled. Since we don't use isInfoEnabled, we're really only concerned about the difference in performance for isDebugEnabled.

Here's the numbers that are concerning:
```
Old FastLogger (rerun)
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1699492309.718          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        569546071.809          ops/s
```
```
New FastLogger (rerun with updated changes)
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1614609085.057          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        554213160.956          ops/s
```
And here's one more run of New FastLogger just to demonstrate variance from run-to-run:
```
New FastLogger (rerun again with updated changes)
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1647331591.312          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        577427794.141          ops/s
```
It comes close to old FastLogger but can't quite catch up on this one.

To really be sure, I think I'd have to run the benchmarks for several longer iterations (overnight). Then we can be more confident of the numbers we're seeing.

I should also point out that wrapping logger.debug statements inside isDebugEnabled guard clauses always outperforms logger.debug by itself for vanilla Logger, old FastLogger and new FastLogger. So as much as we want to be able to remove those guard clauses, I think we may be stuck with them for performance reasons.

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2798: GEODE-5997: Override ExtendedLogger methods in FastLogger

Posted by "kirklund (GitHub)" <gi...@apache.org>.

Below are the results of running FastLoggerBenchmark and FastLoggerParamsBenchmark with the configured settings (which are pretty short):
```
Benchmark                                                      Mode  Cnt           Score   Error  Units
FastLoggerBenchmark.debugLambdaLogStatementWithFastLogger     thrpt       1140378568.819          ops/s
FastLoggerBenchmark.debugLambdaLogStatementWithLogger         thrpt        581609863.899          ops/s
FastLoggerBenchmark.debugLogStatementWithFastLogger           thrpt        983969575.450          ops/s
FastLoggerBenchmark.debugLogStatementWithLogger               thrpt        494294798.393          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithFastLogger      thrpt          4987321.584          ops/s
FastLoggerBenchmark.infoLambdaLogStatementWithLogger          thrpt          4732322.932          ops/s
FastLoggerBenchmark.infoLogStatementWithFastLogger            thrpt          5567982.935          ops/s
FastLoggerBenchmark.infoLogStatementWithLogger                thrpt          5394038.341          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithFastLogger  thrpt       1201945194.555          ops/s
FastLoggerBenchmark.isDebugEnabledLogStatementWithLogger      thrpt        590098348.351          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithFastLogger   thrpt          5639765.772          ops/s
FastLoggerBenchmark.isInfoEnabledLogStatementWithLogger       thrpt          5591034.845          ops/s

Benchmark                                                                                 Mode  Cnt           Score   Error  Units
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithComplexConcat           thrpt       1116586797.172          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLambdaLogStatementWithConcat                  thrpt       1104963621.430          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexConcat                 thrpt            63208.760          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexLambdaParams           thrpt         72440052.162          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithComplexParams                 thrpt        633102739.342          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithConcat                        thrpt         32081069.921          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithLambdaParams                  thrpt         94661455.407          ops/s
FasterLoggerParamsBenchmark.fastLoggerDebugLogStatementWithParams                        thrpt        644039662.975          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithComplexConcat            thrpt            59992.915          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLambdaLogStatementWithConcat                   thrpt          4149139.617          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexConcat                  thrpt            63423.394          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexLambdaParams            thrpt          3124434.749          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithComplexParams                  thrpt          4087878.093          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithConcat                         thrpt          4604518.440          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithLambdaParams                   thrpt          3582505.282          ops/s
FasterLoggerParamsBenchmark.fastLoggerInfoLogStatementWithParams                         thrpt          4444080.268          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexConcat        thrpt       1142947889.813          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexLambdaParams  thrpt       1160009470.068          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithComplexParams        thrpt       1141453898.578          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithConcat               thrpt       1118099749.331          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithLambdaParams         thrpt       1145103424.363          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsDebugEnabledLogStatementWithParams               thrpt       1065989332.803          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithComplexConcat   thrpt            61046.349          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLambdaLogStatementWithConcat          thrpt          4317317.300          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexConcat         thrpt            60507.705          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexLambdaParams   thrpt          3293374.913          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithComplexParams         thrpt          4358819.938          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithConcat                thrpt          4616290.646          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithLambdaParams          thrpt          3596479.899          ops/s
FasterLoggerParamsBenchmark.fastLoggerIsInfoEnabledLogStatementWithParams                thrpt          4094615.116          ops/s
FasterLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithComplexConcat               thrpt        556933807.539          ops/s
FasterLoggerParamsBenchmark.loggerDebugLambdaLogStatementWithConcat                      thrpt        572523916.059          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithComplexConcat                     thrpt            57321.294          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithComplexLambdaParams               thrpt         83977910.327          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithComplexParams                     thrpt        486608883.220          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithConcat                            thrpt         34533973.260          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithLambdaParams                      thrpt         76632932.576          ops/s
FasterLoggerParamsBenchmark.loggerDebugLogStatementWithParams                            thrpt        466369919.883          ops/s
FasterLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithComplexConcat                thrpt            61555.953          ops/s
FasterLoggerParamsBenchmark.loggerInfoLambdaLogStatementWithConcat                       thrpt          4193241.593          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithComplexConcat                      thrpt            61853.767          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithComplexLambdaParams                thrpt          2883375.456          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithComplexParams                      thrpt          4058161.684          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithConcat                             thrpt          3938143.663          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithLambdaParams                       thrpt          3669863.702          ops/s
FasterLoggerParamsBenchmark.loggerInfoLogStatementWithParams                             thrpt          4390586.627          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexConcat            thrpt        515321848.206          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexLambdaParams      thrpt        589155764.117          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithComplexParams            thrpt        587837022.387          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithConcat                   thrpt        561898955.072          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithLambdaParams             thrpt        577965496.685          ops/s
FasterLoggerParamsBenchmark.loggerIsDebugEnabledLogStatementWithParams                   thrpt        589392041.676          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithComplexConcat       thrpt            61586.162          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLambdaLogStatementWithConcat              thrpt          3977824.119          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexConcat             thrpt            58787.252          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexLambdaParams       thrpt          2995286.904          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithComplexParams             thrpt          4130394.631          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithConcat                    thrpt          4584411.374          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithLambdaParams              thrpt          3669342.646          ops/s
FasterLoggerParamsBenchmark.loggerIsInfoEnabledLogStatementWithParams                    thrpt          4396702.939          ops/s
```

[ Full content available at: https://github.com/apache/geode/pull/2798 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org