[GitHub] [cloudstack] olivierlemasle edited a comment on pull request #4193: Fix usage record count

[GitBox <gi...@apache.org>]

olivierlemasle edited a comment on pull request #4193:
URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-688447107


   @Pearl1594 @rhtyd Is that what you proposed?
   
   - First, fix the `count` value with https://github.com/apache/cloudstack/pull/4193/commits/5b5a2e54dd2016481385d3b8558f23280d5047d1 AND return all usage records (incl. usages for IP addresses on networks flagged with "Hide IP address usage", which means reverting temporarily #3235)
   
   - Then, in a separate PR, handle the hiding with a proper solution. I think the best solution (performance-wise) would require a DB schema update: 
     - Adding a flag (e.g. `hidden`) in table `cloud_usage.cloud_usage` ; `listUsageRecords` would then simply filter out these usages.
     - It would also require adding a new column in `cloud_usage.usage_ip_address` to know if the corresponding usage should be hidden. This new flag would be set in`UsageManagerImpl`.
   
   @Pearl1594  Is that what you thought? Do you want me to do the PRs (both or only the second) or do you want to do it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org