[jira] [Commented] (TAP5-2139) When an exception occurs during minification, the asset should be sent unminimized

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703473#comment-13703473 ] 

Howard M. Lewis Ship commented on TAP5-2139:
--------------------------------------------

Perhaps we need some rules to more precisely govern what resources should be minimized and what should not be?  Under 5.4, the resources are compiled and minimized during the page render (so that the URL can be generated, as the URL includes the content checksum) so you have a chance to present the full Tapestry exception report in all its glory.  If we know certain files can't be minimized, then it may be better to not even try, but present a full exception report for files that should be minimized, such as application-specific resources.
                
> When an exception occurs during minification, the asset should be sent unminimized
> ----------------------------------------------------------------------------------
>
>                 Key: TAP5-2139
>                 URL: https://issues.apache.org/jira/browse/TAP5-2139
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-wro4j
>    Affects Versions: 5.4
>            Reporter: Jochen Kemnade
>
> The current closure compiler version fails to minimize angular.js (https://github.com/angular/angular.js/issues/1304). A WroRuntimeException is thrown from GoogleClosureCompressorProcessor which is not handled, so the asset is not sent to the client at all.
> When an asset cannot be minimized for whatever reason, Tapestry should just send the original asset.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira