[GitHub] [tinkerpop] spmallette commented on pull request #1699: fix: Traversal.graph is empty in StepStrategy.apply() with `count().is(0)`

[GitBox <gi...@apache.org>]

spmallette commented on PR #1699:
URL: https://github.com/apache/tinkerpop/pull/1699#issuecomment-1160731883

   sorry no one has had a chance to look at this until now. i think you've identified the problem well. A few things:
   
   1. you supplied an example in the PR description where this was failing, but could you turn that into an actual Gremlin test? 
   1. did you mean to target `master`? i assume this problem goes all the way back to 3.5.3, right? if so could you please retarget your PR for `3.5-dev` branch? 
   1. can you please add a CHANGELOG entry?
   1. i'm concerned this is a wider issue within strategies. i just recently fixed a similar issue in `PartitionStrategy`. i can't help wondering if there is a bigger problem here that needs to be addressed. i dont think strategy authors should have to worry about this detail.  i suppose that needs to be looked at separately from this PR though. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org