[GitHub] [airflow] zhongjiajie commented on a change in pull request #8796: Better help on parameterized breeze commands

[GitBox <gi...@apache.org>]

zhongjiajie commented on a change in pull request #8796:
URL: https://github.com/apache/airflow/pull/8796#discussion_r422517722



##########
File path: breeze
##########
@@ -535,7 +535,7 @@ function prepare_command_files() {
 
     # Prepare script for "run test"
     prepare_command_file "${BUILD_CACHE_DIR}/${LAST_DC_TEST_CI_FILE}" \
-        "${DC_RUN_CI_COMMAND}" "${COMPOSE_CI_FILE}" "true" "${AIRFLOW_CI_IMAGE}" '*'
+        "${DC_RUN_CI_COMMAND}" "true" "${COMPOSE_CI_FILE}" "${AIRFLOW_CI_IMAGE}" '*'

Review comment:
       Why I merged the base PR but it still here

##########
File path: breeze
##########
@@ -804,14 +804,20 @@ function parse_arguments() {
           COMMAND_TO_RUN="cleanup_image"
           shift ;;
         docker-compose)
-          if [[ "$#" -lt 2 ]]; then
+          LAST_SUBCOMMAND="${1}"
+          if [[ $# -lt 2 ]]; then
             echo "You should specify docker compose command to run"
-            exit 1
+            shift
+            RUN_HELP="true"
+          else
+            DOCKER_COMPOSE_COMMAND="${2}"
+            if [[ ${DOCKER_COMPOSE_COMMAND} == "--help" ]]; then
+                RUN_HELP="true"
+            fi

Review comment:
       I test in local and seem delete this three code and `--help` option still work, also the short option `-h`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org