You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2016/04/08 20:23:50 UTC

[compress] Update Java version

I think it would be good to use try-with-resources in our tests and for
users too.

Thoughts on updating to Java 7? Or, gasp, Java 8?

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [compress] Update Java version

Posted by Jeremy Gustie <jg...@blackducksoftware.com>.
Oracle claims “extended support” for Java 6 until the end of 2018[1], so there are still going to be a few environments out there that benefit from Java 6 support. That said, there are some more disruptive changes that could take advantage of new Java 7 APIs:

For something like COMPRESS-327 it would allow the use of SeekableByteChannel for in memory access to archive types that benefit from random access.

The java.nio.file.attribute interfaces (BasicFileAttributes along with sub-types PosixFileAttributes and DosFileAttributes) offer a good abstraction for normalizing ArchiveEntry subclass (see Stefan’s work[2]). Also, the FileTime class is a good immutable alternative to Java 8’s Instant.

I would say maintain Java 6 support in 1.x and go with Java 7 in 2.x.

-Jeremy

[1]: http://www.oracle.com/technetwork/java/eol-135779.html
[2]: https://github.com/blackducksoftware/commons-compress/commit/c6eed140b0b4579fd11ade0b66ada704bb116eca

> On Apr 8, 2016, at 2:43 PM, sebb <se...@gmail.com> wrote:
> 
> On 8 April 2016 at 19:23, Gary Gregory <ga...@gmail.com> wrote:
>> I think it would be good to use try-with-resources in our tests and for
>> users too.
> 
> Does not affect users directly.
> 
>> Thoughts on updating to Java 7?
> 
> Why, apart from try with resources?
> What are the benefits for the end user?
> 
>> Or, gasp, Java 8?
> 
> -1
> 
>> Gary
>> 
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [compress] Update Java version

Posted by sebb <se...@gmail.com>.
On 8 April 2016 at 19:23, Gary Gregory <ga...@gmail.com> wrote:
> I think it would be good to use try-with-resources in our tests and for
> users too.

Does not affect users directly.

> Thoughts on updating to Java 7?

Why, apart from try with resources?
What are the benefits for the end user?

>  Or, gasp, Java 8?

-1

> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [compress] Update Java version

Posted by sebb <se...@gmail.com>.
+1 for Java6.

On 9 April 2016 at 05:30, Gary Gregory <ga...@gmail.com> wrote:
> Java 6 seems like a no brainer IMO.
>
> G
>
> On Fri, Apr 8, 2016 at 9:05 PM, Stefan Bodewig <bo...@apache.org> wrote:
>
>> On 2016-04-08, Gary Gregory wrote:
>>
>> > I think it would be good to use try-with-resources in our tests and for
>> > users too.
>>
>> > Thoughts on updating to Java 7? Or, gasp, Java 8?
>>
>> I've had to fix some Java6ism a couple of times after applying patches
>> like @Override on interface implementations - I even had to back out the
>> PowerMockito unit test for an applied pull request, so I'd be in favor
>> of moving to Java6. I could get talked into moving to Java7, but Java8
>> seems a little too much for me.
>>
>> The compress2 branch I created requires Java8.
>>
>> Stefan
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [compress] Update Java version

Posted by Gary Gregory <ga...@gmail.com>.
Java 6 seems like a no brainer IMO.

G

On Fri, Apr 8, 2016 at 9:05 PM, Stefan Bodewig <bo...@apache.org> wrote:

> On 2016-04-08, Gary Gregory wrote:
>
> > I think it would be good to use try-with-resources in our tests and for
> > users too.
>
> > Thoughts on updating to Java 7? Or, gasp, Java 8?
>
> I've had to fix some Java6ism a couple of times after applying patches
> like @Override on interface implementations - I even had to back out the
> PowerMockito unit test for an applied pull request, so I'd be in favor
> of moving to Java6. I could get talked into moving to Java7, but Java8
> seems a little too much for me.
>
> The compress2 branch I created requires Java8.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [compress] Update Java version

Posted by Stefan Bodewig <bo...@apache.org>.
On 2016-04-08, Gary Gregory wrote:

> I think it would be good to use try-with-resources in our tests and for
> users too.

> Thoughts on updating to Java 7? Or, gasp, Java 8?

I've had to fix some Java6ism a couple of times after applying patches
like @Override on interface implementations - I even had to back out the
PowerMockito unit test for an applied pull request, so I'd be in favor
of moving to Java6. I could get talked into moving to Java7, but Java8
seems a little too much for me.

The compress2 branch I created requires Java8.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org