[GitHub] srkukarni commented on a change in pull request #3299: Cleanup consumer subscriptions and fix graceful shutdown for functions/sinks

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #3299:  Cleanup consumer subscriptions and fix graceful shutdown for functions/sinks
URL: https://github.com/apache/pulsar/pull/3299#discussion_r246981615
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/Function.proto
 ##########
 @@ -98,6 +98,7 @@ message SourceSpec {
      * already present in the server */
     string builtin = 8;
     string subscriptionName = 9;
+    bool cleanupSubscription = 11;
 
 Review comment:
   while you are trying to set cleanupSubscription in FunctionConfig.java to true if not specified, we need to also do similar things when we get the Function/Source/Sink Config in the worker side of things(since things could be submitted outside of cmdline tool). 
   I think a better way is to have a dontcleanSubscription everywhere. The fact that the default value of boolean is false will immensly help in code complexity that way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services