You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/07/05 11:26:00 UTC
Review Request 60653: Tightened namespace to fix a lookup error on
Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60653/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
Repository: mesos
Description
-------
Tightened namespace to fix a lookup error on Windows.
Diffs
-----
src/resource_provider/daemon.cpp 243396dfe735c0ee421071dfc5df3c9d1c103e45
Diff: https://reviews.apache.org/r/60653/diff/1/
Testing
-------
make check and made sure it compiles with Windows.
Thanks,
Jan Schlicht
Re: Review Request 60653: Tightened namespace to fix a lookup error on
Windows.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60653/#review179632
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On July 5, 2017, 1:58 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60653/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 1:58 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Visual C++ compiler tried to lookup 'protobuf::parse' in the
> 'mesos::internal::protobuf' namespace. This is fixed by explicitly
> setting the namespace.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.cpp 243396dfe735c0ee421071dfc5df3c9d1c103e45
>
>
> Diff: https://reviews.apache.org/r/60653/diff/3/
>
>
> Testing
> -------
>
> make check and made sure it compiles with Windows.
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 60653: Tightened namespace to fix a lookup error on
Windows.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60653/
-----------------------------------------------------------
(Updated July 5, 2017, 3:58 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
Repository: mesos
Description
-------
The Visual C++ compiler tried to lookup 'protobuf::parse' in the
'mesos::internal::protobuf' namespace. This is fixed by explicitly
setting the namespace.
Diffs (updated)
-----
src/resource_provider/daemon.cpp 243396dfe735c0ee421071dfc5df3c9d1c103e45
Diff: https://reviews.apache.org/r/60653/diff/3/
Changes: https://reviews.apache.org/r/60653/diff/2-3/
Testing
-------
make check and made sure it compiles with Windows.
Thanks,
Jan Schlicht
Re: Review Request 60653: Tightened namespace to fix a lookup error on
Windows.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60653/
-----------------------------------------------------------
(Updated July 5, 2017, 2:28 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
Repository: mesos
Description (updated)
-------
The Visual C++ compiler tried to lookup 'protobuf::parse' in the
'mesos::internal::protobuf' namespace. This is fixed by explicitly
setting the namespace.
Diffs (updated)
-----
src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e
src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79
src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a
src/master/master.hpp 95c2d0fab32d6b60f29a86037607ff009bd78717
src/master/master.cpp 56b170ed70722eba30d98f6e648b6a31580d6b56
src/resource_provider/daemon.cpp 243396dfe735c0ee421071dfc5df3c9d1c103e45
src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f
src/tests/persistent_volume_endpoints_tests.cpp a66bde2619732c0f9bea6eb5364737077b96e51d
src/tests/reservation_endpoints_tests.cpp 05b505fc4c643f56c7141b6b79f334b000470780
Diff: https://reviews.apache.org/r/60653/diff/2/
Changes: https://reviews.apache.org/r/60653/diff/1-2/
Testing
-------
make check and made sure it compiles with Windows.
Thanks,
Jan Schlicht
Re: Review Request 60653: Tightened namespace to fix a lookup error on
Windows.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60653/#review179622
-----------------------------------------------------------
Ship it!
Could you update the commit message to maybe include there error we were seeing? Might also be worth calling at that we use this pattern elsewhere already when calling `protobuf::parse`.
- Benjamin Bannier
On July 5, 2017, 1:26 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60653/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 1:26 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Tightened namespace to fix a lookup error on Windows.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.cpp 243396dfe735c0ee421071dfc5df3c9d1c103e45
>
>
> Diff: https://reviews.apache.org/r/60653/diff/1/
>
>
> Testing
> -------
>
> make check and made sure it compiles with Windows.
>
>
> Thanks,
>
> Jan Schlicht
>
>