You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2018/05/29 17:42:54 UTC
[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10526
Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload
......................................................................
IMPALA-7088: Fix uninitialized variable in cluster dataload
bin/load-data.py uses a unique directory for local Hive
execution to avoid a race condition when executing multiple
Hive commands at once. This unique directory is not needed
when loading on a real cluster. However, the code to remove
the unique directory at the end does not handle this
correctly.
This skips the code to remove the unique directory when
it is uninitialized.
Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
---
M bin/load-data.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/10526/1
--
To view, visit http://gerrit.cloudera.org:8080/10526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
Gerrit-Change-Number: 10526
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10526 )
Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload
......................................................................
IMPALA-7088: Fix uninitialized variable in cluster dataload
bin/load-data.py uses a unique directory for local Hive
execution to avoid a race condition when executing multiple
Hive commands at once. This unique directory is not needed
when loading on a real cluster. However, the code to remove
the unique directory at the end does not handle this
correctly.
This skips the code to remove the unique directory when
it is uninitialized.
Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
Reviewed-on: http://gerrit.cloudera.org:8080/10526
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/load-data.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
Gerrit-Change-Number: 10526
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10526
to look at the new patch set (#2).
Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload
......................................................................
IMPALA-7088: Fix uninitialized variable in cluster dataload
bin/load-data.py uses a unique directory for local Hive
execution to avoid a race condition when executing multiple
Hive commands at once. This unique directory is not needed
when loading on a real cluster. However, the code to remove
the unique directory at the end does not handle this
correctly.
This skips the code to remove the unique directory when
it is uninitialized.
Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
---
M bin/load-data.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/10526/2
--
To view, visit http://gerrit.cloudera.org:8080/10526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
Gerrit-Change-Number: 10526
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 )
Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10526/1/bin/load-data.py
File bin/load-data.py:
http://gerrit.cloudera.org:8080/#/c/10526/1/bin/load-data.py@170
PS1, Line 170: if (unique_dir):
> python nit: you don't need the parens here.
Good point.
--
To view, visit http://gerrit.cloudera.org:8080/10526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
Gerrit-Change-Number: 10526
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 May 2018 17:54:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 )
Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
Gerrit-Change-Number: 10526
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 May 2018 21:34:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 )
Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2562/
--
To view, visit http://gerrit.cloudera.org:8080/10526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
Gerrit-Change-Number: 10526
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 May 2018 18:09:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 )
Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10526/1/bin/load-data.py
File bin/load-data.py:
http://gerrit.cloudera.org:8080/#/c/10526/1/bin/load-data.py@170
PS1, Line 170: if (unique_dir):
python nit: you don't need the parens here.
--
To view, visit http://gerrit.cloudera.org:8080/10526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
Gerrit-Change-Number: 10526
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 May 2018 17:44:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 )
Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload
......................................................................
Patch Set 2: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/10526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5581a45460dc341842d77eaa09647e50f35be6c7
Gerrit-Change-Number: 10526
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 May 2018 17:54:28 +0000
Gerrit-HasComments: No