You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/11/10 23:12:02 UTC
Review Request 63742: Add service dependencies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63742/
-----------------------------------------------------------
Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar.
Bugs: AMBARI-22345
https://issues.apache.org/jira/browse/AMBARI-22345
Repository: ambari
Description
-------
Second part of patch. Did some code cleanup. Also reimplemented API and BE to use sevice dependency id.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java afdfcc4
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java 97fe502
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java d8d89da
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterServiceDAO.java 0eeb19b
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java 976bb67
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDependencyEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 27d37e3
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java c4c2d84
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java bfb04be
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 755a80f
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e1e7c9e
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b438e69
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql aab7f95
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8832818
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 135707b
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 7d93aad
ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5
Diff: https://reviews.apache.org/r/63742/diff/1/
Testing
-------
Thanks,
Vitalyi Brodetskyi
Re: Review Request 63742: Add service dependencies
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63742/#review190786
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Nov. 10, 2017, 11:11 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63742/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2017, 11:11 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar.
>
>
> Bugs: AMBARI-22345
> https://issues.apache.org/jira/browse/AMBARI-22345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Second part of patch. Did some code cleanup. Also reimplemented API and BE to use sevice dependency id.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java afdfcc4
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java 97fe502
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java d8d89da
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterServiceDAO.java 0eeb19b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java 976bb67
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDependencyEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 27d37e3
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java c4c2d84
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java bfb04be
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 755a80f
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e1e7c9e
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b438e69
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql aab7f95
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8832818
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 135707b
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 7d93aad
> ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5
>
>
> Diff: https://reviews.apache.org/r/63742/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>