You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/04/06 17:29:54 UTC
[GitHub] [solr] HoustonPutman opened a new pull request, #789: Fix integration test cleanup & bats tmp directory
HoustonPutman opened a new pull request, #789:
URL: https://github.com/apache/solr/pull/789
Also fix logging for configSet, noticed that the directories specified were wrong when I was getting test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a diff in pull request #789: Fix integration test cleanup & bats tmp directory
Posted by GitBox <gi...@apache.org>.
madrob commented on code in PR #789:
URL: https://github.com/apache/solr/pull/789#discussion_r845347842
##########
solr/packaging/test/test_bats.bats:
##########
@@ -21,7 +21,7 @@ load bats_helper
setup_file() {
# set up paths and helpers
- common_setup
+ common_clean_setup
Review Comment:
Either a comment here (in test_bats) since that is supposed to be our documented example, or a function on bats_helper since that is where the function is declared. Not required on each use of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #789: Fix integration test cleanup & bats tmp directory
Posted by GitBox <gi...@apache.org>.
madrob commented on PR #789:
URL: https://github.com/apache/solr/pull/789#issuecomment-1092058847
Does this fix [SOLR-16143](https://issues.apache.org/jira/browse/SOLR-16143)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a diff in pull request #789: Fix integration test cleanup & bats tmp directory
Posted by GitBox <gi...@apache.org>.
madrob commented on code in PR #789:
URL: https://github.com/apache/solr/pull/789#discussion_r844245229
##########
solr/packaging/test/test_create_collection.bats:
##########
@@ -18,12 +18,12 @@
load bats_helper
setup_file() {
- common_setup
+ common_clean_setup
solr start -c
local source_configset_dir="$SOLR_TIP/server/solr/configsets/sample_techproducts_configs"
test -d $source_configset_dir
- cp -r $source_configset_dir "$BATS_TMPDIR/config"
+ cp -r "${source_configset_dir}" "$BATS_FILE_TMPDIR/config"
Review Comment:
Since this is only used by one test, can we move it to that test? Then I think we would use `BATS_TEST_TMPDIR`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a diff in pull request #789: Fix integration test cleanup & bats tmp directory
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on code in PR #789:
URL: https://github.com/apache/solr/pull/789#discussion_r845249028
##########
solr/packaging/test/test_bats.bats:
##########
@@ -21,7 +21,7 @@ load bats_helper
setup_file() {
# set up paths and helpers
- common_setup
+ common_clean_setup
Review Comment:
Put the comment on the function in `bats_helper` or for each of the uses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a diff in pull request #789: Fix integration test cleanup & bats tmp directory
Posted by GitBox <gi...@apache.org>.
madrob commented on code in PR #789:
URL: https://github.com/apache/solr/pull/789#discussion_r844248548
##########
solr/packaging/test/test_bats.bats:
##########
@@ -21,7 +21,7 @@ load bats_helper
setup_file() {
# set up paths and helpers
- common_setup
+ common_clean_setup
Review Comment:
Can you add a comment here about how this is different from `common_setup` (and possibly point out that we don't want to call it in teardown)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #789: Fix integration test cleanup & bats tmp directory
Posted by GitBox <gi...@apache.org>.
madrob commented on PR #789:
URL: https://github.com/apache/solr/pull/789#issuecomment-1092077151
Just realized that this would delete the log output after failure, (on next test file) so we wouldn't be able to get diagnostic information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman merged pull request #789: SOLR-16143: Fix integration test cleanup & bats tmp directory
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged PR #789:
URL: https://github.com/apache/solr/pull/789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org