You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/09/07 01:27:44 UTC
Review Request 62146: SENTRY-1929 When full HMS snapshot is created
all higher notifications should be purged
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/
-----------------------------------------------------------
Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
Bugs: SENTRY-1929
https://issues.apache.org/jira/browse/SENTRY-1929
Repository: sentry
Description
-------
SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
Diff: https://reviews.apache.org/r/62146/diff/1/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
> On Sept. 7, 2017, 2:20 a.m., Vamsee Yarlagadda wrote:
> > IMPORTANT:
> > http://github.mtv.cloudera.com/CDH/sentry/blob/cdh5-1.5.1/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java#L307-L312
> > We should handle the case when the HDFSSync is also not enabled. Currently we only purge when the sync is present but ideally this should be done in both the cases.
This gets even more complicated. We should also cleanup CounterWait() otherwise the log is being cluttered as:
```bash
2017-09-06 19:56:21,655 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 821 is smaller then the previous one 9025
2017-09-06 19:56:21,659 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 822 is smaller then the previous one 9025
2017-09-06 19:56:21,677 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 823 is smaller then the previous one 9025
2017-09-06 19:56:21,693 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 824 is smaller then the previous one 9025
2017-09-06 19:56:22,116 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 824 is smaller then the previous one 9025
2017-09-06 19:56:22,144 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 824 is smaller then the previous one 9025
2017-09-06 19:56:22,160 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 825 is smaller then the previous one 9025
2017-09-06 19:56:22,177 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 826 is smaller then the previous one 9025
2017-09-06 19:56:22,617 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 826 is smaller then the previous one 9025
2017-09-06 19:56:22,646 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 826 is smaller then the previous one 9025
2017-09-06 19:56:23,116 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 826 is smaller then the previous one 9025
2017-09-06 19:56:23,145 ERROR org.apache.sentry.service.thrift.CounterWait: new counter value 826 is smaller then the previous one 9025
```
- Vamsee
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184776
-----------------------------------------------------------
On Sept. 7, 2017, 1:27 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62146/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 1:27 a.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1929
> https://issues.apache.org/jira/browse/SENTRY-1929
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
>
>
> Diff: https://reviews.apache.org/r/62146/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184776
-----------------------------------------------------------
IMPORTANT:
http://github.mtv.cloudera.com/CDH/sentry/blob/cdh5-1.5.1/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java#L307-L312
We should handle the case when the HDFSSync is also not enabled. Currently we only purge when the sync is present but ideally this should be done in both the cases.
- Vamsee Yarlagadda
On Sept. 7, 2017, 1:27 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62146/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 1:27 a.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1929
> https://issues.apache.org/jira/browse/SENTRY-1929
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
>
>
> Diff: https://reviews.apache.org/r/62146/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184769
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On Sept. 7, 2017, 1:27 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62146/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 1:27 a.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1929
> https://issues.apache.org/jira/browse/SENTRY-1929
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
>
>
> Diff: https://reviews.apache.org/r/62146/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Sept. 7, 2017, 7:17 a.m., Vamsee Yarlagadda wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java
> > Lines 138 (patched)
> > <https://reviews.apache.org/r/62146/diff/2/?file=1817042#file1817042line138>
> >
> > What about pending waiters on the higher notification ID's?
The reason we are doing this is because waiters are now waitinng on smaller values. We can't wake up these waiters because this is a violation of the contract - the value is not reached yet. The use case for this is when our notifications got backwards which means that no HMS waiters should wait on old values. If they do, they'll eventually time out.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184795
-----------------------------------------------------------
On Sept. 7, 2017, 7:06 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62146/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 7:06 a.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1929
> https://issues.apache.org/jira/browse/SENTRY-1929
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java 9c9bb69e768a1e648bb16e8c7efaa6ca6edea797
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d4feb380fa0f3bd5f237609a107295a2d23eae3b
>
>
> Diff: https://reviews.apache.org/r/62146/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184795
-----------------------------------------------------------
Fix it, then Ship it!
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java
Lines 138 (patched)
<https://reviews.apache.org/r/62146/#comment260994>
What about pending waiters on the higher notification ID's?
- Vamsee Yarlagadda
On Sept. 7, 2017, 7:06 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62146/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 7:06 a.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1929
> https://issues.apache.org/jira/browse/SENTRY-1929
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java 9c9bb69e768a1e648bb16e8c7efaa6ca6edea797
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d4feb380fa0f3bd5f237609a107295a2d23eae3b
>
>
> Diff: https://reviews.apache.org/r/62146/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184887
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Sept. 7, 2017, 8:06 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62146/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 8:06 a.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1929
> https://issues.apache.org/jira/browse/SENTRY-1929
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java 9c9bb69e768a1e648bb16e8c7efaa6ca6edea797
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d4feb380fa0f3bd5f237609a107295a2d23eae3b
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java 93afb614d0916c60ca416f8904331e78dd1b85d2
>
>
> Diff: https://reviews.apache.org/r/62146/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184885
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On Sept. 7, 2017, 8:06 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62146/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 8:06 a.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1929
> https://issues.apache.org/jira/browse/SENTRY-1929
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java 9c9bb69e768a1e648bb16e8c7efaa6ca6edea797
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d4feb380fa0f3bd5f237609a107295a2d23eae3b
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java 93afb614d0916c60ca416f8904331e78dd1b85d2
>
>
> Diff: https://reviews.apache.org/r/62146/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Sept. 7, 2017, 4:03 p.m., Na Li wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
> > Lines 402 (patched)
> > <https://reviews.apache.org/r/62146/diff/3/?file=1817058#file1817058line402>
> >
> > I don't see CounterWait has the function reset(). did you forget to upload change of this file?
It is there if you click on CounterWait.java file. It is included in this review.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184824
-----------------------------------------------------------
On Sept. 7, 2017, 8:06 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62146/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 8:06 a.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1929
> https://issues.apache.org/jira/browse/SENTRY-1929
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java 9c9bb69e768a1e648bb16e8c7efaa6ca6edea797
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d4feb380fa0f3bd5f237609a107295a2d23eae3b
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java 93afb614d0916c60ca416f8904331e78dd1b85d2
>
>
> Diff: https://reviews.apache.org/r/62146/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184824
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 402 (patched)
<https://reviews.apache.org/r/62146/#comment261016>
I don't see CounterWait has the function reset(). did you forget to upload change of this file?
- Na Li
On Sept. 7, 2017, 8:06 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62146/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 8:06 a.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1929
> https://issues.apache.org/jira/browse/SENTRY-1929
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java 9c9bb69e768a1e648bb16e8c7efaa6ca6edea797
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d4feb380fa0f3bd5f237609a107295a2d23eae3b
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java 93afb614d0916c60ca416f8904331e78dd1b85d2
>
>
> Diff: https://reviews.apache.org/r/62146/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/
-----------------------------------------------------------
(Updated Sept. 7, 2017, 8:06 a.m.)
Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Fixed TestHMSFollower
Bugs: SENTRY-1929
https://issues.apache.org/jira/browse/SENTRY-1929
Repository: sentry
Description
-------
SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java 9c9bb69e768a1e648bb16e8c7efaa6ca6edea797
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d4feb380fa0f3bd5f237609a107295a2d23eae3b
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java 93afb614d0916c60ca416f8904331e78dd1b85d2
Diff: https://reviews.apache.org/r/62146/diff/3/
Changes: https://reviews.apache.org/r/62146/diff/2-3/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 62146: SENTRY-1929 When full HMS snapshot is
created all higher notifications should be purged
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/
-----------------------------------------------------------
(Updated Sept. 7, 2017, 7:06 a.m.)
Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Addressed code review comments from Vamsee:
- Remove newer notifications when HDFS sync is disabled
- Reset waiting counter as well
Bugs: SENTRY-1929
https://issues.apache.org/jira/browse/SENTRY-1929
Repository: sentry
Description
-------
SENTRY-1929 When full HMS snapshot is created all higher notifications should be purged
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java 9c9bb69e768a1e648bb16e8c7efaa6ca6edea797
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java d4feb380fa0f3bd5f237609a107295a2d23eae3b
Diff: https://reviews.apache.org/r/62146/diff/2/
Changes: https://reviews.apache.org/r/62146/diff/1-2/
Testing
-------
Thanks,
Alexander Kolbasov