You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/26 10:00:19 UTC
[GitHub] [airflow] Dr-Denzy opened a new pull request #14475: Use CustomSQLAInterface instead of SQLAInterface
Dr-Denzy opened a new pull request #14475:
URL: https://github.com/apache/airflow/pull/14475
for custom data models.
From Airflow 2.0, if you want to define your own Flask App Builder
models you need to use CustomSQLAInterface instead of SQLAInterface.
For Non-RBAC replace:
`from flask_appbuilder.models.sqla.interface import SQLAInterface`
`datamodel = SQLAInterface(your_data_model)`
with RBAC (in 1.10):
`from airflow.www_rbac.utils import CustomSQLAInterface`
`datamodel = CustomSQLAInterface(your_data_model)`
and in 2.0:
`from airflow.www.utils import CustomSQLAInterface`
`datamodel = CustomSQLAInterface(your_data_model)`
related: #13226
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14475: Use CustomSQLAInterface instead of SQLAInterface
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14475:
URL: https://github.com/apache/airflow/pull/14475#discussion_r583591462
##########
File path: airflow/upgrade/rules/use_customsqlainterface_class_rule.py
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+
+
+class UseCustomSQLAInterfaceClassRule(BaseRule):
+ title = "Use CustomSQLAInterface instead of SQLAInterface for custom data models."
+
+ description = """\
+From Airflow 2.0, if you want to define your own Flask App Builder models you need to
+use CustomSQLAInterface instead of SQLAInterface.
+
+For Non-RBAC replace:
+
+`from flask_appbuilder.models.sqla.interface import SQLAInterface`
+`datamodel = SQLAInterface(your_data_model)`
+
+with RBAC (in 1.10):
+
+`from airflow.www_rbac.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+
+and in 2.0:
+
+`from airflow.www.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+ """
+
+ def check(self):
+
+ from airflow.plugins_manager import flask_appbuilder_views
+
+ plugins_with_sqlainterface_data_model_instance = []
+
+ if flask_appbuilder_views:
+ for view_obj in flask_appbuilder_views:
+ for attr in dir(view_obj.get("view")):
+ if type(getattr(view_obj.get("view"), attr)).__name__ == 'SQLAInterface':
+ plugins_with_sqlainterface_data_model_instance.append(view_obj.get("name"))
Review comment:
Should we also check if RBAC has been enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14475: Use CustomSQLAInterface instead of SQLAInterface
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14475:
URL: https://github.com/apache/airflow/pull/14475#discussion_r583589759
##########
File path: airflow/upgrade/rules/use_customsqlainterface_class_rule.py
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+
+
+class UseCustomSQLAInterfaceClassRule(BaseRule):
+ title = "Use CustomSQLAInterface instead of SQLAInterface for custom data models."
+
+ description = """\
+From Airflow 2.0, if you want to define your own Flask App Builder models you need to
+use CustomSQLAInterface instead of SQLAInterface.
+
+For Non-RBAC replace:
+
+`from flask_appbuilder.models.sqla.interface import SQLAInterface`
+`datamodel = SQLAInterface(your_data_model)`
+
+with RBAC (in 1.10):
+
+`from airflow.www_rbac.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+
+and in 2.0:
+
+`from airflow.www.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+ """
+
+ def check(self):
+
+ from airflow.plugins_manager import flask_appbuilder_views
+
+ plugins_with_sqlainterface_data_model_instance = []
+
+ if flask_appbuilder_views:
+ for view_obj in flask_appbuilder_views:
+ for attr in dir(view_obj.get("view")):
+ if type(getattr(view_obj.get("view"), attr)).__name__ == 'SQLAInterface':
+ plugins_with_sqlainterface_data_model_instance.append(view_obj.get("name"))
Review comment:
Is there any other instancee other than `datamodel` where `SQLInterface` can be used?
##########
File path: airflow/upgrade/rules/use_customsqlainterface_class_rule.py
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+
+
+class UseCustomSQLAInterfaceClassRule(BaseRule):
+ title = "Use CustomSQLAInterface instead of SQLAInterface for custom data models."
+
+ description = """\
+From Airflow 2.0, if you want to define your own Flask App Builder models you need to
+use CustomSQLAInterface instead of SQLAInterface.
+
+For Non-RBAC replace:
+
+`from flask_appbuilder.models.sqla.interface import SQLAInterface`
+`datamodel = SQLAInterface(your_data_model)`
+
+with RBAC (in 1.10):
+
+`from airflow.www_rbac.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+
+and in 2.0:
+
+`from airflow.www.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+ """
+
+ def check(self):
+
+ from airflow.plugins_manager import flask_appbuilder_views
+
+ plugins_with_sqlainterface_data_model_instance = []
+
+ if flask_appbuilder_views:
+ for view_obj in flask_appbuilder_views:
+ for attr in dir(view_obj.get("view")):
+ if type(getattr(view_obj.get("view"), attr)).__name__ == 'SQLAInterface':
+ plugins_with_sqlainterface_data_model_instance.append(view_obj.get("name"))
Review comment:
Is there any other instance other than `datamodel` where `SQLInterface` can be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Dr-Denzy commented on a change in pull request #14475: Use CustomSQLAInterface instead of SQLAInterface
Posted by GitBox <gi...@apache.org>.
Dr-Denzy commented on a change in pull request #14475:
URL: https://github.com/apache/airflow/pull/14475#discussion_r583606485
##########
File path: airflow/upgrade/rules/use_customsqlainterface_class_rule.py
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+
+
+class UseCustomSQLAInterfaceClassRule(BaseRule):
+ title = "Use CustomSQLAInterface instead of SQLAInterface for custom data models."
+
+ description = """\
+From Airflow 2.0, if you want to define your own Flask App Builder models you need to
+use CustomSQLAInterface instead of SQLAInterface.
+
+For Non-RBAC replace:
+
+`from flask_appbuilder.models.sqla.interface import SQLAInterface`
+`datamodel = SQLAInterface(your_data_model)`
+
+with RBAC (in 1.10):
+
+`from airflow.www_rbac.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+
+and in 2.0:
+
+`from airflow.www.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+ """
+
+ def check(self):
+
+ from airflow.plugins_manager import flask_appbuilder_views
+
+ plugins_with_sqlainterface_data_model_instance = []
+
+ if flask_appbuilder_views:
+ for view_obj in flask_appbuilder_views:
+ for attr in dir(view_obj.get("view")):
+ if type(getattr(view_obj.get("view"), attr)).__name__ == 'SQLAInterface':
+ plugins_with_sqlainterface_data_model_instance.append(view_obj.get("name"))
Review comment:
Just realised `datamodel` is a required property. https://flask-appbuilder.readthedocs.io/en/latest/quickhowto.html#define-your-views-views-py
That simplifies everything! I will refactor the code now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] foresmac commented on a change in pull request #14475: Use CustomSQLAInterface instead of SQLAInterface
Posted by GitBox <gi...@apache.org>.
foresmac commented on a change in pull request #14475:
URL: https://github.com/apache/airflow/pull/14475#discussion_r796966064
##########
File path: airflow/upgrade/rules/use_customsqlainterface_class_rule.py
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.www_rbac.utils import CustomSQLAInterface
+
+
+class UseCustomSQLAInterfaceClassRule(BaseRule):
+ title = "Use CustomSQLAInterface instead of SQLAInterface for custom data models."
+
+ description = """\
+From Airflow 2.0, if you want to define your own Flask App Builder models you need to
+use CustomSQLAInterface instead of SQLAInterface.
+
+For Non-RBAC replace:
+
+`from flask_appbuilder.models.sqla.interface import SQLAInterface`
+`datamodel = SQLAInterface(your_data_model)`
+
+with RBAC (in 1.10):
+
+`from airflow.www_rbac.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+
+and in 2.0:
+
+`from airflow.www.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+ """
+
+ def check(self):
+
+ from airflow.plugins_manager import flask_appbuilder_views
+
+ plugins_with_sqlainterface_data_model_instance = []
+
+ if flask_appbuilder_views:
+ for view_obj in flask_appbuilder_views:
+ if not isinstance(view_obj.get("view").datamodel, CustomSQLAInterface):
Review comment:
I don't think this conditional is correct. We have `SimpleFormView` subclasses that don't use a `datamodel` attribute and it just causes the upgrade script to crash. Nothing I can find in the flask docs or code suggest that having `datamodel` attribute is _required_. Therefore I think this should be replaced with the following:
```python
if hasattr(view_obj, "datamodel") and not isinstance(view_obj.get("view").datamodel, CustomSQLAInterface):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14475: Use CustomSQLAInterface instead of SQLAInterface
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14475:
URL: https://github.com/apache/airflow/pull/14475#issuecomment-786978473
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #14475: Use CustomSQLAInterface instead of SQLAInterface
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #14475:
URL: https://github.com/apache/airflow/pull/14475#discussion_r797037115
##########
File path: airflow/upgrade/rules/use_customsqlainterface_class_rule.py
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.www_rbac.utils import CustomSQLAInterface
+
+
+class UseCustomSQLAInterfaceClassRule(BaseRule):
+ title = "Use CustomSQLAInterface instead of SQLAInterface for custom data models."
+
+ description = """\
+From Airflow 2.0, if you want to define your own Flask App Builder models you need to
+use CustomSQLAInterface instead of SQLAInterface.
+
+For Non-RBAC replace:
+
+`from flask_appbuilder.models.sqla.interface import SQLAInterface`
+`datamodel = SQLAInterface(your_data_model)`
+
+with RBAC (in 1.10):
+
+`from airflow.www_rbac.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+
+and in 2.0:
+
+`from airflow.www.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+ """
+
+ def check(self):
+
+ from airflow.plugins_manager import flask_appbuilder_views
+
+ plugins_with_sqlainterface_data_model_instance = []
+
+ if flask_appbuilder_views:
+ for view_obj in flask_appbuilder_views:
+ if not isinstance(view_obj.get("view").datamodel, CustomSQLAInterface):
Review comment:
There are no moe releases to 1.10 / upgrade checker as it's EOL.
If you found a bug then you can disable the specific rule and create your own custom rule with a fix.
##########
File path: airflow/upgrade/rules/use_customsqlainterface_class_rule.py
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.www_rbac.utils import CustomSQLAInterface
+
+
+class UseCustomSQLAInterfaceClassRule(BaseRule):
+ title = "Use CustomSQLAInterface instead of SQLAInterface for custom data models."
+
+ description = """\
+From Airflow 2.0, if you want to define your own Flask App Builder models you need to
+use CustomSQLAInterface instead of SQLAInterface.
+
+For Non-RBAC replace:
+
+`from flask_appbuilder.models.sqla.interface import SQLAInterface`
+`datamodel = SQLAInterface(your_data_model)`
+
+with RBAC (in 1.10):
+
+`from airflow.www_rbac.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+
+and in 2.0:
+
+`from airflow.www.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+ """
+
+ def check(self):
+
+ from airflow.plugins_manager import flask_appbuilder_views
+
+ plugins_with_sqlainterface_data_model_instance = []
+
+ if flask_appbuilder_views:
+ for view_obj in flask_appbuilder_views:
+ if not isinstance(view_obj.get("view").datamodel, CustomSQLAInterface):
Review comment:
There are no more releases to 1.10 / upgrade checker as it's EOL.
If you found a bug then you can disable the specific rule and create your own custom rule with a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14475: Use CustomSQLAInterface instead of SQLAInterface
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14475:
URL: https://github.com/apache/airflow/pull/14475#discussion_r583650732
##########
File path: airflow/upgrade/rules/use_customsqlainterface_class_rule.py
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.www_rbac.utils import CustomSQLAInterface
+
+
+class UseCustomSQLAInterfaceClassRule(BaseRule):
+ title = "Use CustomSQLAInterface instead of SQLAInterface for custom data models."
+
+ description = """\
+From Airflow 2.0, if you want to define your own Flask App Builder models you need to
+use CustomSQLAInterface instead of SQLAInterface.
+
+For Non-RBAC replace:
+
+`from flask_appbuilder.models.sqla.interface import SQLAInterface`
+`datamodel = SQLAInterface(your_data_model)`
+
+with RBAC (in 1.10):
+
+`from airflow.www_rbac.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+
+and in 2.0:
+
+`from airflow.www.utils import CustomSQLAInterface`
+`datamodel = CustomSQLAInterface(your_data_model)`
+ """
+
+ def check(self):
+
+ from airflow.plugins_manager import flask_appbuilder_views
+
+ plugins_with_sqlainterface_data_model_instance = []
+
+ if flask_appbuilder_views:
Review comment:
if this only applies for RBAC, maybe we should also do:
```suggestion
from airflow import settings
if setttings.RBAC and flask_appbuilder_views:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14475: Use CustomSQLAInterface instead of SQLAInterface
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14475:
URL: https://github.com/apache/airflow/pull/14475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org