You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/05/03 03:09:19 UTC

[GitHub] beam pull request #2852: [BEAM-1340,BEAM-1345] Tight up access and use inter...

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2852

    [BEAM-1340,BEAM-1345] Tight up access and use internal annotations a bit in the Java SDK

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    This is a pass over `sdk.runners`, `sdk.transforms`, `sdk.transforms.reflect` (which is entirely internal), `sdk.transforms.windowing` trigger parts, and `sdk.values`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam Internal

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2852.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2852
    
----
commit 664eca296a6310399e71ff350e611c06519db9cf
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-05-03T02:31:22Z

    Annotate internal methods of PCollection

commit 4f61e779e4575a96083bb6ef3d80e29499c544ab
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-05-03T02:48:38Z

    Annotate internal pieces of sdks.transforms

commit c003770a2fc2549e123788cdea97019d7896c9ff
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-05-03T02:59:32Z

    Tighten access control and internal annotations for triggers

commit 9d365b14d5fb6c0992424a28e08b40263a6c6536
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-05-03T03:05:34Z

    The transforms.reflect package is not for users

commit 2e62dcd1075210d1ea0411484b0184b7c8431f4c
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-05-03T03:05:45Z

    Annotate internal-only bits of Java sdk.runners

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2852: [BEAM-1340,BEAM-1345] Tighten up access and use int...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2852


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---