[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4212: Add ObjectStore::get_opts (#2241)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4212:
URL: https://github.com/apache/arrow-rs/pull/4212#discussion_r1193649074


##########
object_store/src/aws/mod.rs:
##########
@@ -246,39 +247,26 @@ impl ObjectStore for AmazonS3 {
             .await
     }
 
-    async fn get(&self, location: &Path) -> Result<GetResult> {
-        let response = self.client.get_request(location, None, false).await?;
+    async fn get_opts(&self, location: &Path, options: GetOptions) -> Result<GetResult> {
+        let response = self.client.get_request(location, options, false).await?;
         let stream = response
             .bytes_stream()
             .map_err(|source| crate::Error::Generic {
-                store: "S3",
+                store: STORE,
                 source: Box::new(source),
             })
             .boxed();
 
         Ok(GetResult::Stream(stream))
     }
 
-    async fn get_range(&self, location: &Path, range: Range<usize>) -> Result<Bytes> {

Review Comment:
   The default implementation is sufficient



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org