You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Reser <be...@reser.org> on 2014/03/07 23:18:31 UTC
FSX pack test failure
I'm seeing the following pack test failure on Ubuntu 12.04 x64 with trunk at
r1575427:
{{{
make check FS_TYPE=fsx TESTS=subversion/tests/libsvn_fs_x/fs-x-pack-test
[1/1]
fs-x-pack-test......................................................................FAILURE
At least one test FAILED, checking /home/breser/wandisco/builds/svn-trunk/tests.log
FAIL: lt-fs-x-pack-test 1: pack a FSX filesystem
FAIL: lt-fs-x-pack-test 3: read from a packed FSX filesystem
FAIL: lt-fs-x-pack-test 12: test packing with shard size = 1
Summary of test results:
9 tests PASSED
3 tests FAILED
SUMMARY: Some tests failed.
make: *** [check] Error 1
{!570 #72 Ubuntu 12.04/x86_64 Fri Mar 07 14:15:18 -0800}
[breser@precise64 svn-trunk]$ cat fails.log
[[[
/home/breser/wandisco/share/wcs/svn-trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c:287,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c:185,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs/fs-loader.c:844,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:2232,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:3271,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:272,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:255,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:3124,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:2541,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:2282,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:1735,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:380,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:323,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_subr/cache-membuffer.c:2784,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_subr/cache-membuffer.c:2280,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/noderevs.c:906,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/noderevs.c:365: (apr_err=SVN_ERR_FS_CONTAINER_INDEX)
svn_tests: E160057: Node revision ID index 542509633 exceeds container size 16
FAIL: lt-fs-x-pack-test 1: pack a FSX filesystem
]]]
[[[
/home/breser/wandisco/share/wcs/svn-trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c:407,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs/fs-loader.c:1384,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:2891,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:1239,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:1055,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:1181,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:317,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:441,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:165,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:380,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:323,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_subr/cache-membuffer.c:2784,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_subr/cache-membuffer.c:2280,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/noderevs.c:908,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/noderevs.c:365: (apr_err=SVN_ERR_FS_CONTAINER_INDEX)
svn_tests: E160057: Node revision ID index 170991691 exceeds container size 28
FAIL: lt-fs-x-pack-test 3: read from a packed FSX filesystem
]]]
[[[
/home/breser/wandisco/share/wcs/svn-trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c:851,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c:185,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs/fs-loader.c:844,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:2232,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:3271,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:272,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:255,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:3206,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:2746,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:4438,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:4329,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:197,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:165,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:380,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:353,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:2682,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:2517,
/home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/noderevs.c:436: (apr_err=SVN_ERR_FS_CONTAINER_INDEX)
svn_tests: E160057: Node revision index 20 exceeds container size 20
FAIL: lt-fs-x-pack-test 12: test packing with shard size = 1
]]]
}}}
The test does not fail on OS X for me.
I managed to binary search my way back to r1567023 which is when the tests
started failing. I'm starting to dig into why now but since r1567023 is a
rather non-trivial change I'm sending the mail now in case stefan2 can just pop
in and fix it.
Re: FSX pack test failure
Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Fri, Mar 7, 2014 at 11:18 PM, Ben Reser <be...@reser.org> wrote:
> I'm seeing the following pack test failure on Ubuntu 12.04 x64 with trunk
> at
> r1575427:
> {{{
> make check FS_TYPE=fsx TESTS=subversion/tests/libsvn_fs_x/fs-x-pack-test
> [1/1]
>
> fs-x-pack-test......................................................................FAILURE
> At least one test FAILED, checking
> /home/breser/wandisco/builds/svn-trunk/tests.log
> FAIL: lt-fs-x-pack-test 1: pack a FSX filesystem
> FAIL: lt-fs-x-pack-test 3: read from a packed FSX filesystem
> FAIL: lt-fs-x-pack-test 12: test packing with shard size = 1
> Summary of test results:
> 9 tests PASSED
> 3 tests FAILED
> SUMMARY: Some tests failed.
>
> make: *** [check] Error 1
>
> {!570 #72 Ubuntu 12.04/x86_64 Fri Mar 07 14:15:18 -0800}
> [breser@precise64 svn-trunk]$ cat fails.log
> [[[
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c:287,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c:185,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs/fs-loader.c:844,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:2232,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:3271,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:272,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:255,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:3124,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:2541,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:2282,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:1735,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:380,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:323,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_subr/cache-membuffer.c:2784,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_subr/cache-membuffer.c:2280,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/noderevs.c:906,
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/noderevs.c:365:
> (apr_err=SVN_ERR_FS_CONTAINER_INDEX)
> svn_tests: E160057: Node revision ID index 542509633 exceeds container
> size 16
> FAIL: lt-fs-x-pack-test 1: pack a FSX filesystem
> ]]]
>
> [[[
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c:407,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs/fs-loader.c:1384,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:2891,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:1239,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:1055,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:1181,
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:317,
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:441,
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:165,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:380,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:323,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_subr/cache-membuffer.c:2784,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_subr/cache-membuffer.c:2280,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/noderevs.c:908,
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/noderevs.c:365:
> (apr_err=SVN_ERR_FS_CONTAINER_INDEX)
> svn_tests: E160057: Node revision ID index 170991691 exceeds container
> size 28
> FAIL: lt-fs-x-pack-test 3: read from a packed FSX filesystem
> ]]]
>
> [[[
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c:851,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/tests/libsvn_fs_x/fs-x-pack-test.c:185,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs/fs-loader.c:844,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:2232,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:3271,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:272,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:255,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:3206,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/transaction.c:2746,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:4438,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/tree.c:4329,
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:197,
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/dag.c:165,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:380,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:353,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:2682,
>
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/cached_data.c:2517,
> /home/breser/wandisco/share/wcs/svn-trunk/subversion/libsvn_fs_x/noderevs.c:436:
> (apr_err=SVN_ERR_FS_CONTAINER_INDEX)
> svn_tests: E160057: Node revision index 20 exceeds container size 20
> FAIL: lt-fs-x-pack-test 12: test packing with shard size = 1
> ]]]
> }}}
>
> The test does not fail on OS X for me.
>
> I managed to binary search my way back to r1567023 which is when the tests
> started failing. I'm starting to dig into why now but since r1567023 is a
> rather non-trivial change I'm sending the mail now in case stefan2 can
> just pop
> in and fix it.
>
I sharp look at the diff uncovered a simple of off-by-one error.
r1575642 should fix the problem.
-- Stefan^2.
Re: FSX pack test failure
Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Fri, Mar 7, 2014 at 11:18 PM, Ben Reser <be...@reser.org> wrote:
> I'm seeing the following pack test failure on Ubuntu 12.04 x64 with trunk
> at
> r1575427:
> {{{
> make check FS_TYPE=fsx TESTS=subversion/tests/libsvn_fs_x/fs-x-pack-test
> [1/1]
>
> fs-x-pack-test......................................................................FAILURE
> At least one test FAILED, checking
> /home/breser/wandisco/builds/svn-trunk/tests.log
> FAIL: lt-fs-x-pack-test 1: pack a FSX filesystem
> FAIL: lt-fs-x-pack-test 3: read from a packed FSX filesystem
> FAIL: lt-fs-x-pack-test 12: test packing with shard size = 1
> Summary of test results:
> 9 tests PASSED
> 3 tests FAILED
> SUMMARY: Some tests failed.
>
> make: *** [check] Error 1
>
>
I don't see these failures here but they look like
missing initialization.
I managed to binary search my way back to r1567023 which is when the tests
> started failing. I'm starting to dig into why now but since r1567023 is a
> rather non-trivial change I'm sending the mail now in case stefan2 can
> just pop
> in and fix it.
>
I'll have a look at them tomorrow. Since I'm back
at home next Tuesday, my 12.04 machine there
should be able to reproduce the problems.
So, if you want to dig into that code, be my guest.
But the failure might actually be due to the changed
ID behavior (as opposed to a simple coding oversight)
which is in a transient state anyways.
-- Stefan^2.