[GitHub] spark pull request #16986: [SPARK-18891][SQL] Support for Map collection typ...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16986#discussion_r117160501
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala ---
    @@ -329,35 +329,19 @@ object ScalaReflection extends ScalaReflection {
             }
             UnresolvedMapObjects(mapFunction, getPath, Some(cls))
     
    -      case t if t <:< localTypeOf[Map[_, _]] =>
    +      case t if t <:< localTypeOf[Map[_, _]] || t <:< localTypeOf[java.util.Map[_, _]] =>
    --- End diff --
    
    we should handle java map in `JavaTypeInference`, but I think it's better to do it in another PR and focus on scala map in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org