You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/04/14 03:39:43 UTC

[GitHub] [incubator-pekko] pjfanning opened a new pull request, #285: update links to point to pekko sample docs

pjfanning opened a new pull request, #285:
URL: https://github.com/apache/incubator-pekko/pull/285

   some samples that are referenced in pekko docs are not in https://github.com/apache/incubator-pekko-samples - so I have set those links up to work the old Akka docs way (and link to the Akka sample)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin merged pull request #285: update links to point to pekko sample docs

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #285:
URL: https://github.com/apache/incubator-pekko/pull/285


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #285: update links to point to pekko sample docs

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #285:
URL: https://github.com/apache/incubator-pekko/pull/285#discussion_r1166353337


##########
project/Paradox.scala:
##########
@@ -35,8 +35,8 @@ object Paradox {
       "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
       "extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
       "extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
-      "extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&amp;project=%s",
-      "extref.ecs.base_url" -> "https://example.lightbend.com/v1/download/%s",
+      "extref.samples.base_url" -> s"$pekkoBaseURL/docs/pekko-samples/current/%s",
+      "extref.akka-samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&amp;project=%s",
       "pekko.doc.dns" -> s"$pekkoBaseURL",

Review Comment:
   https://developer.lightbend.com/start/?group=akka&project=%s
   
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #285: update links to point to pekko sample docs

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #285:
URL: https://github.com/apache/incubator-pekko/pull/285#discussion_r1166695940


##########
project/Paradox.scala:
##########
@@ -35,8 +35,8 @@ object Paradox {
       "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
       "extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
       "extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
-      "extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&amp;project=%s",
-      "extref.ecs.base_url" -> "https://example.lightbend.com/v1/download/%s",
+      "extref.samples.base_url" -> s"$pekkoBaseURL/docs/pekko-samples/current/%s",
+      "extref.akka-samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&amp;project=%s",
       "pekko.doc.dns" -> s"$pekkoBaseURL",

Review Comment:
   @pjfanning what's the `&amp` in the `akka-sample.base_url`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #285: update links to point to pekko sample docs

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #285:
URL: https://github.com/apache/incubator-pekko/pull/285#discussion_r1166699040


##########
project/Paradox.scala:
##########
@@ -35,8 +35,8 @@ object Paradox {
       "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
       "extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
       "extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
-      "extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&amp;project=%s",
-      "extref.ecs.base_url" -> "https://example.lightbend.com/v1/download/%s",
+      "extref.samples.base_url" -> s"$pekkoBaseURL/docs/pekko-samples/current/%s",
+      "extref.akka-samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&amp;project=%s",
       "pekko.doc.dns" -> s"$pekkoBaseURL",

Review Comment:
   `&amp;` escapes `&`. This value is not new. I've just changed the extref prefix that maps to it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #285: update links to point to pekko sample docs

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #285:
URL: https://github.com/apache/incubator-pekko/pull/285#discussion_r1166493721


##########
project/Paradox.scala:
##########
@@ -35,8 +35,8 @@ object Paradox {
       "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
       "extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
       "extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
-      "extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&amp;project=%s",
-      "extref.ecs.base_url" -> "https://example.lightbend.com/v1/download/%s",
+      "extref.samples.base_url" -> s"$pekkoBaseURL/docs/pekko-samples/current/%s",
+      "extref.akka-samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&amp;project=%s",
       "pekko.doc.dns" -> s"$pekkoBaseURL",

Review Comment:
   We don't have Pekko versions of all the samples. `"extref.akka-samples.base_url"` has the same value as the previous setting for `"extref.samples.base_url"`. I've changed some of the `extref` settings in the docs to use this `akka-samples` based link - so that the generated link URL remains as before - because the `samples` based links have been changed to link to Pekko URLs if and when there is an actual working Pekko sample to link to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org