You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2025/07/31 09:12:49 UTC
[PR] GH-3253: Apply ServicesResourceTransformer to parquet-jackson [parquet-java]
pan3793 opened a new pull request, #3260:
URL: https://github.com/apache/parquet-java/pull/3260
<!--
Thanks for opening a pull request!
If you're new to Parquet-Java, information on how to contribute can be found here: https://parquet.apache.org/docs/contribution-guidelines/contributing
Please open a GitHub issue for this pull request: https://github.com/apache/parquet-java/issues/new/choose
and format pull request title as below:
GH-${GITHUB_ISSUE_ID}: ${SUMMARY}
or simply use the title below if it is a minor issue:
MINOR: ${SUMMARY}
-->
### Rationale for this change
Fix #3253
### What changes are included in this PR?
As the title.
### Are these changes tested?
Before
<img width="487" height="164" alt="image" src="https://github.com/user-attachments/assets/6b4893a9-1b7a-4b0c-a52f-9223bb460832" />
After
<img width="494" height="164" alt="Xnip2025-07-31_17-08-35" src="https://github.com/user-attachments/assets/e44cfe3e-c145-42f2-8f1d-47fc20e95a06" />
### Are there any user-facing changes?
No.
<!-- Please uncomment the line below and replace ${GITHUB_ISSUE_ID} with the actual Github issue id. -->
Closes #3253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-3253: Apply ServicesResourceTransformer to parquet-jackson [parquet-java]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #3260:
URL: https://github.com/apache/parquet-java/pull/3260#issuecomment-3149865329
> can the shaded services interfere with a potential official Jackson library on the classpath?
No, as long as `ServicesResourceTransformer` is applied, it relocates both the service interface and implementation class name.
<img width="1111" height="396" alt="image" src="https://github.com/user-attachments/assets/3889fe08-419b-4a72-9e82-c2c242b6ac72" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-3253: Apply ServicesResourceTransformer to parquet-jackson [parquet-java]
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on PR #3260:
URL: https://github.com/apache/parquet-java/pull/3260#issuecomment-3149671051
@pan3793, could you elaborate a bit more on what is happening here? The jackson based services are not available currently because of the shading, right? Which means, that parquet-java does not use them. We do not want to make them available. We are shading jackson, so systems depending on parquet-java would not use it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-3253: Apply ServicesResourceTransformer to parquet-jackson [parquet-java]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #3260:
URL: https://github.com/apache/parquet-java/pull/3260#issuecomment-3149776111
> parquet-java does not use them
@gszadovszky Probably right, because I haven't seen user reports issues related to that. But this can not be proven by UT, because currently, Maven UT always runs against vanilla Jackson libs, class relocation only happens on packaging.
Anyway, we should either correctly transform those service files or purge them.
Generally, applying `ServicesResourceTransformer` is preferred to keep the functionality completeness of the shaded libs, for example, we generally keep all classes of the shaded lib instead of keeping only the used classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-3253: Apply ServicesResourceTransformer to parquet-jackson [parquet-java]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #3260:
URL: https://github.com/apache/parquet-java/pull/3260#issuecomment-3139163057
cc @LDVSOFT who reports this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-3253: Apply ServicesResourceTransformer to parquet-jackson [parquet-java]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #3260:
URL: https://github.com/apache/parquet-java/pull/3260#issuecomment-3144919395
cc @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-3253: Apply ServicesResourceTransformer to parquet-jackson [parquet-java]
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on PR #3260:
URL: https://github.com/apache/parquet-java/pull/3260#issuecomment-3149840147
@pan3793, can the shaded services interfere with a potential official Jackson library on the classpath? If not, I'm good with this. If yes, we should rather purge the services that we are not using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-3253: Apply ServicesResourceTransformer to parquet-jackson [parquet-java]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #3260:
URL: https://github.com/apache/parquet-java/pull/3260#issuecomment-3146588432
I'm not familiar with this. Could you help review this? @gszadovszky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-3253: Apply ServicesResourceTransformer to parquet-jackson [parquet-java]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #3260:
URL: https://github.com/apache/parquet-java/pull/3260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org