You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Suraj Khurana (Jira)" <ji...@apache.org> on 2020/09/13 06:07:00 UTC
[jira] [Closed] (OFBIZ-11947) Checkstyle: Add Javadoc for classes
designed for extension
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suraj Khurana closed OFBIZ-11947.
---------------------------------
Fix Version/s: Upcoming Branch
Resolution: Implemented
Last pair of patches fixed around *45* checkstyle issues.
> Checkstyle: Add Javadoc for classes designed for extension
> ----------------------------------------------------------
>
> Key: OFBIZ-11947
> URL: https://issues.apache.org/jira/browse/OFBIZ-11947
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Suraj Khurana
> Assignee: Suraj Khurana
> Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11947-2.patch, OFBIZ-11947-3.patch, OFBIZ-11947-plugins-3.patch, OFBIZ-11947-plugins.patch, OFBIZ-11947.patch
>
>
> For checkstyle errors:
> Class 'ResourceInfo' looks like designed for extension (can be subclassed), but the method 'createResourceHandler' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ResourceInfo' final or making the method 'createResourceHandler' static/final/abstract/empty, or adding allowed annotation for the method.
> We need to add missing javadocs for all such methods
--
This message was sent by Atlassian Jira
(v8.3.4#803005)