You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2016/12/15 22:29:06 UTC
[06/10] incubator-beam git commit: Removes unused code from
NoOpOldDoFn
Removes unused code from NoOpOldDoFn
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/ca1dd7a3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/ca1dd7a3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/ca1dd7a3
Branch: refs/heads/master
Commit: ca1dd7a3a4a01e2696a8131809c5798aef55d6a0
Parents: f3e8a03
Author: Eugene Kirpichov <ki...@google.com>
Authored: Fri Dec 9 17:24:23 2016 -0800
Committer: Eugene Kirpichov <ki...@google.com>
Committed: Thu Dec 15 13:58:43 2016 -0800
----------------------------------------------------------------------
.../apache/beam/sdk/transforms/NoOpOldDoFn.java | 72 --------------------
1 file changed, 72 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/ca1dd7a3/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/NoOpOldDoFn.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/NoOpOldDoFn.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/NoOpOldDoFn.java
index 302b66a..504480b 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/NoOpOldDoFn.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/NoOpOldDoFn.java
@@ -19,10 +19,6 @@ package org.apache.beam.sdk.transforms;
import org.apache.beam.sdk.options.PipelineOptions;
import org.apache.beam.sdk.transforms.Combine.CombineFn;
-import org.apache.beam.sdk.transforms.windowing.BoundedWindow;
-import org.apache.beam.sdk.transforms.windowing.PaneInfo;
-import org.apache.beam.sdk.util.WindowingInternals;
-import org.apache.beam.sdk.values.PCollectionView;
import org.apache.beam.sdk.values.TupleTag;
import org.joda.time.Instant;
@@ -46,13 +42,6 @@ class NoOpOldDoFn<InputT, OutputT> extends OldDoFn<InputT, OutputT> {
}
/**
- * Returns a new NoOp Process Context.
- */
- public OldDoFn<InputT, OutputT>.ProcessContext processContext() {
- return new NoOpDoFnProcessContext();
- }
-
- /**
* A {@link OldDoFn.Context} that does nothing and returns exclusively null.
*/
private class NoOpDoFnContext extends OldDoFn<InputT, OutputT>.Context {
@@ -79,65 +68,4 @@ class NoOpOldDoFn<InputT, OutputT> extends OldDoFn<InputT, OutputT> {
return null;
}
}
-
- /**
- * A {@link OldDoFn.ProcessContext} that does nothing and returns exclusively
- * null.
- */
- private class NoOpDoFnProcessContext extends OldDoFn<InputT, OutputT>.ProcessContext {
- @Override
- public InputT element() {
- return null;
- }
-
- @Override
- public <T> T sideInput(PCollectionView<T> view) {
- return null;
- }
-
- @Override
- public Instant timestamp() {
- return null;
- }
-
- @Override
- public BoundedWindow window() {
- return null;
- }
-
- @Override
- public PaneInfo pane() {
- return null;
- }
-
- @Override
- public WindowingInternals<InputT, OutputT> windowingInternals() {
- return null;
- }
-
- @Override
- public PipelineOptions getPipelineOptions() {
- return null;
- }
-
- @Override
- public void output(OutputT output) {}
-
- @Override
- public void outputWithTimestamp(OutputT output, Instant timestamp) {}
-
- @Override
- public <T> void sideOutput(TupleTag<T> tag, T output) {}
-
- @Override
- public <T> void sideOutputWithTimestamp(TupleTag<T> tag, T output,
- Instant timestamp) {}
-
- @Override
- protected <AggInputT, AggOutputT> Aggregator<AggInputT, AggOutputT>
- createAggregatorInternal(String name, CombineFn<AggInputT, ?, AggOutputT> combiner) {
- return null;
- }
-
- }
}