You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/24 17:36:37 UTC
[GitHub] [incubator-tvm] michalpiszczek opened a new pull request #5437: [TFLite Runtime] Add TFLite Runtime dependencies to CI CPU docker build
michalpiszczek opened a new pull request #5437:
URL: https://github.com/apache/incubator-tvm/pull/5437
This PR contains only the docker build changes needed to re-enable the tests in: https://github.com/apache/incubator-tvm/pull/5436.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] u99127 commented on a change in pull request #5437: [TFLite Runtime] Add TFLite Runtime dependencies to CI CPU docker build
Posted by GitBox <gi...@apache.org>.
u99127 commented on a change in pull request #5437:
URL: https://github.com/apache/incubator-tvm/pull/5437#discussion_r414830870
##########
File path: docker/install/ubuntu_install_tflite.sh
##########
@@ -26,12 +26,18 @@ cd flatbuffers
cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release
make install -j8
cd ..
-rm -rf flatbuffers
# Install flatbuffers python packages.
pip3 install flatbuffers
pip2 install flatbuffers
+# Build the TFLite static library, necessary for building with TFLite ON.
+# The library is built at:
+# tensorflow/tensorflow/lite/tools/make/gen/*/lib/libtensorflow-lite.a.
+git clone https://github.com/tensorflow/tensorflow --branch=r2.0
Review comment:
why not 2.1.0 which is the latest stable version and what we install in the tree. I don’t think it’s worth the version skew.
Ramana
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] michalpiszczek commented on a change in pull request #5437: [TFLite Runtime] Add TFLite Runtime dependencies to CI CPU docker build
Posted by GitBox <gi...@apache.org>.
michalpiszczek commented on a change in pull request #5437:
URL: https://github.com/apache/incubator-tvm/pull/5437#discussion_r414833737
##########
File path: docker/install/ubuntu_install_tflite.sh
##########
@@ -26,12 +26,18 @@ cd flatbuffers
cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release
make install -j8
cd ..
-rm -rf flatbuffers
# Install flatbuffers python packages.
pip3 install flatbuffers
pip2 install flatbuffers
+# Build the TFLite static library, necessary for building with TFLite ON.
+# The library is built at:
+# tensorflow/tensorflow/lite/tools/make/gen/*/lib/libtensorflow-lite.a.
+git clone https://github.com/tensorflow/tensorflow --branch=r2.0
Review comment:
@u99127 Good catch, thank you. I noticed your PR updating the version yesterday but I forgot I was specifying 2.0 here. Will update :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org