You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2020/02/24 03:19:05 UTC

[logging-log4j2] branch release-2.x updated: Remove Serializable

This is an automated email from the ASF dual-hosted git repository.

rgoers pushed a commit to branch release-2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git


The following commit(s) were added to refs/heads/release-2.x by this push:
     new 694505f  Remove Serializable
694505f is described below

commit 694505f06dae0e231064a80564bf31be4e0363c0
Author: Ralph Goers <rg...@apache.org>
AuthorDate: Sun Feb 23 20:18:54 2020 -0700

    Remove Serializable
---
 log4j-api/revapi.json                                    | 16 +++++-----------
 .../apache/logging/log4j/internal/DefaultLogBuilder.java |  3 +--
 2 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/log4j-api/revapi.json b/log4j-api/revapi.json
index 0c95daa..d362403 100644
--- a/log4j-api/revapi.json
+++ b/log4j-api/revapi.json
@@ -38,17 +38,11 @@
         "justification": "LOG4J2-2639 - Add builder pattern to Logger interface"
       },
       {
-        "code": "java.field.serialVersionUIDChanged",
-        "new": "field org.apache.logging.log4j.internal.DefaultLogBuilder.serialVersionUID",
-        "oldSerialVersionUID": "-4931273176502023439",
-        "newSerialVersionUID": "8851553895299192531",
-        "justification": "New overloaded methods added",
-        "package": "org.apache.logging.log4j.internal",
-        "classQualifiedName": "org.apache.logging.log4j.internal.DefaultLogBuilder",
-        "classSimpleName": "DefaultLogBuilder",
-        "fieldName": "serialVersionUID",
-        "newArchive": "org.apache.logging.log4j:log4j-api:jar:2.13.1-SNAPSHOT",
-        "elementKind": "field"
+        "code": "java.class.noLongerImplementsInterface",
+        "old": "class org.apache.logging.log4j.internal.DefaultLogBuilder",
+        "new": "class org.apache.logging.log4j.internal.DefaultLogBuilder",
+        "interface": "java.io.Serializable",
+        "justification": "Internal class that should not be Serializable."
       }
     ]
   }
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/internal/DefaultLogBuilder.java b/log4j-api/src/main/java/org/apache/logging/log4j/internal/DefaultLogBuilder.java
index 0db3e70..f2e8c8f 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/internal/DefaultLogBuilder.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/internal/DefaultLogBuilder.java
@@ -33,9 +33,8 @@ import org.apache.logging.log4j.util.Supplier;
 /**
  * Collects data for a log event and then logs it. This class should be considered private.
  */
-public class DefaultLogBuilder implements LogBuilder, Serializable {
+public class DefaultLogBuilder implements LogBuilder {
 
-    private static final long serialVersionUID = 8851553895299192531L;
     private static Message EMPTY_MESSAGE = new SimpleMessage("");
     private static final String FQCN = DefaultLogBuilder.class.getName();
     private static final Logger LOGGER = StatusLogger.getLogger();