You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/05/15 14:16:56 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #6353: Fix expected output

alamb opened a new pull request, #6353:
URL: https://github.com/apache/arrow-datafusion/pull/6353

   # Which issue does this PR close?
   
   I believe https://github.com/apache/arrow-datafusion/pull/6271 had a logical merge conflict
   
   # Rationale for this change
   
   CI is failing on master. It should be fixed 
   
   # What changes are included in this PR?
   
   update sqllogictest output
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6353: Fix expected output

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6353:
URL: https://github.com/apache/arrow-datafusion/pull/6353#discussion_r1193912043


##########
datafusion/core/tests/sqllogictests/test_files/explain.slt:
##########
@@ -147,8 +147,7 @@ analyzed_logical_plan SAME TEXT AS ABOVE
 logical_plan after simplify_expressions SAME TEXT AS ABOVE
 logical_plan after unwrap_cast_in_comparison SAME TEXT AS ABOVE
 logical_plan after replace_distinct_aggregate SAME TEXT AS ABOVE
-logical_plan after decorrelate_where_exists SAME TEXT AS ABOVE

Review Comment:
   This is the real change (as two rules were combined)
   
   The rest of this PR is a consequence of running `cargo test --test sqllogictests -- --complete` and checking in the result



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #6353: Fix expected output

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6353:
URL: https://github.com/apache/arrow-datafusion/pull/6353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6353: Fix expected output

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6353:
URL: https://github.com/apache/arrow-datafusion/pull/6353#issuecomment-1548052321

   Thanks @r4ntix 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org