[GitHub] [ignite] ibessonov commented on a change in pull request #6305: IGNITE-11569 Enable baseline auto-adjust by default only for empty cl…

[GitBox <gi...@apache.org>]

ibessonov commented on a change in pull request #6305: IGNITE-11569 Enable baseline auto-adjust by default only for empty cl…
URL: https://github.com/apache/ignite/pull/6305#discussion_r267308513
 
 

 ##########
 File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cluster/ChangeTopologyWatcherTest.java
 ##########
 @@ -344,4 +345,43 @@ public void testBaselineAutoAdjustIgnoreClientNodes() throws Exception {
 
         assertTrue(isCurrentBaselineFromOneNode(ignite0));
     }
+
+    /**
+     * @throws Exception if failed.
+     */
+    @Test
+    public void testBaselineAutoAdjustDisableByDefaultBecauseNotNewCluster() throws Exception {
+        System.setProperty(IGNITE_BASELINE_AUTO_ADJUST_ENABLED, "false");
+        try {
+            Ignite ignite0 = startGrids(2);
+
+            ignite0.cluster().active(true);
+
+            ignite0.cluster().baselineAutoAdjustTimeout(0);
+
+            stopAllGrids();
+        }
+        finally {
+            System.clearProperty(IGNITE_BASELINE_AUTO_ADJUST_ENABLED);
+        }
+
+        Ignite ignite0 = startGrids(2);
+
+        ignite0.cluster().active(true);
+
+        Set<Object> initBaseline = ignite0.cluster().currentBaselineTopology().stream()
 
 Review comment:
   I think that it would be much easier to read if you compared size of baseline nodes set, not their ids. Is that ok?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services