You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/09/20 05:01:59 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #545: ORC-667: Positional mapping for nested struct types should not applied by default

dongjoon-hyun commented on a change in pull request #545:
URL: https://github.com/apache/orc/pull/545#discussion_r491652983



##########
File path: java/core/src/java/org/apache/orc/impl/SchemaEvolution.java
##########
@@ -513,7 +513,7 @@ void buildConversion(TypeDescription fileType,
             isOnlyImplicitConversion = false;
           }
 
-          if (positionalLevels == 0) {
+          if (positionalLevels <= 0) {

Review comment:
       This can be negative because of ORC-667.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org