You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2023/06/20 09:54:15 UTC

[GitHub] [doris] zclllyybb opened a new pull request, #21027: [fix](log) fix the too large warning log of BE

zclllyybb opened a new pull request, #21027:
URL: https://github.com/apache/doris/pull/21027

   ## Proposed changes
   
   Issue Number: close #xxx
   
   the be.WARNING log file is too large because of the profile informations when PipelineTask canceled. Now add a switch to control it.
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zclllyybb commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600572966

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600393305

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zclllyybb commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600580117

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600799340

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600796080

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zclllyybb commented on a diff in pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #21027:
URL: https://github.com/apache/doris/pull/21027#discussion_r1235036746


##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -326,7 +327,9 @@ std::string PipelineTask::debug_string() {
     {
         std::stringstream profile_ss;
         _fresh_profile_counter();
-        _task_profile->pretty_print(&profile_ss, "");
+        if (config::enable_detail_failed_log) {

Review Comment:
   indeed. fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1598485237

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zclllyybb commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600478393

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zclllyybb commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600388745

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600583409

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zclllyybb commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1598498539

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1601079367

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600488909

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1598478760

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #21027:
URL: https://github.com/apache/doris/pull/21027#discussion_r1236596435


##########
be/src/pipeline/task_scheduler.cpp:
##########
@@ -278,8 +278,8 @@ void TaskScheduler::_do_work(size_t index) {
 
         task->set_previous_core_id(index);
         if (!status.ok()) {

Review Comment:
   I think warning should be used here, because `status` may return some internal errors



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zclllyybb commented on a diff in pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #21027:
URL: https://github.com/apache/doris/pull/21027#discussion_r1236612208


##########
be/src/pipeline/task_scheduler.cpp:
##########
@@ -278,8 +278,8 @@ void TaskScheduler::_do_work(size_t index) {
 
         task->set_previous_core_id(index);
         if (!status.ok()) {

Review Comment:
   how do you think if we print a WARNING message of PipelineTask failure, and print verbose information in INFO?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600796636

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1598492166

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei commented on a diff in pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #21027:
URL: https://github.com/apache/doris/pull/21027#discussion_r1235439278


##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -335,15 +336,20 @@ std::string PipelineTask::debug_string() {
         fmt::format_to(debug_string_buffer, "\n{}{}", std::string(i * 2, ' '),
                        _operators[i]->debug_string());
         std::stringstream profile_ss;
-        _operators[i]->get_runtime_profile()->pretty_print(&profile_ss, std::string(i * 2, ' '));
+        if (config::enable_detail_failed_log) {
+            _operators[i]->get_runtime_profile()->pretty_print(&profile_ss,
+                                                               std::string(i * 2, ' '));
+        }
         fmt::format_to(debug_string_buffer, "\n{}", profile_ss.str());
     }
     fmt::format_to(debug_string_buffer, "\n{}{}", std::string(_operators.size() * 2, ' '),
                    _sink->debug_string());
     {
         std::stringstream profile_ss;
-        _sink->get_runtime_profile()->pretty_print(&profile_ss,
-                                                   std::string(_operators.size() * 2, ' '));
+        if (config::enable_detail_failed_log) {

Review Comment:
   这种config 都没什么意义,如果大家都这么搞config,还用vlog 这种干啥呢



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zclllyybb commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600791261

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] xiaokang merged pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #21027:
URL: https://github.com/apache/doris/pull/21027


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #21027:
URL: https://github.com/apache/doris/pull/21027#discussion_r1235031840


##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -326,7 +327,9 @@ std::string PipelineTask::debug_string() {
     {
         std::stringstream profile_ss;
         _fresh_profile_counter();
-        _task_profile->pretty_print(&profile_ss, "");
+        if (config::enable_detail_failed_log) {

Review Comment:
   no need change this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1598485305

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei commented on a diff in pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #21027:
URL: https://github.com/apache/doris/pull/21027#discussion_r1235439278


##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -335,15 +336,20 @@ std::string PipelineTask::debug_string() {
         fmt::format_to(debug_string_buffer, "\n{}{}", std::string(i * 2, ' '),
                        _operators[i]->debug_string());
         std::stringstream profile_ss;
-        _operators[i]->get_runtime_profile()->pretty_print(&profile_ss, std::string(i * 2, ' '));
+        if (config::enable_detail_failed_log) {
+            _operators[i]->get_runtime_profile()->pretty_print(&profile_ss,
+                                                               std::string(i * 2, ' '));
+        }
         fmt::format_to(debug_string_buffer, "\n{}", profile_ss.str());
     }
     fmt::format_to(debug_string_buffer, "\n{}{}", std::string(_operators.size() * 2, ' '),
                    _sink->debug_string());
     {
         std::stringstream profile_ss;
-        _sink->get_runtime_profile()->pretty_print(&profile_ss,
-                                                   std::string(_operators.size() * 2, ' '));
+        if (config::enable_detail_failed_log) {

Review Comment:
   这种config 都没什么意义,如果大家都这么搞config,还用vlog 这种干啥呢
   然后每个feature 都可以加一个log的config,太乱了啊



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] HappenLee commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1599985751

   Dubug string only be call in debug mode or use vlog to check whether print the log


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #21027:
URL: https://github.com/apache/doris/pull/21027#discussion_r1236678880


##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -24,6 +24,7 @@
 
 #include <ostream>
 
+#include "common/config.h"

Review Comment:
   unused include?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21027:
URL: https://github.com/apache/doris/pull/21027#issuecomment-1600581084

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org