You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/02/14 23:18:05 UTC

[GitHub] [beam] hengfengli commented on a change in pull request #16845: [BEAM-12164]: allow to specify a custom metadata table for Spanner Change Streams Connector

hengfengli commented on a change in pull request #16845:
URL: https://github.com/apache/beam/pull/16845#discussion_r806318809



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##########
@@ -1496,8 +1505,10 @@ public ReadChangeStream withTraceSampleProbability(Double probability) {
               getMetadataInstance(), changeStreamDatabaseId.getInstanceId().getInstance());
       final String partitionMetadataDatabaseId =
           MoreObjects.firstNonNull(getMetadataDatabase(), changeStreamDatabaseId.getDatabase());
-      final String partitionMetadataTableName =
-          generatePartitionMetadataTableName(partitionMetadataDatabaseId);
+      String partitionMetadataTableName = getMetadataTableName();

Review comment:
       Good catch. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org