[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #350: Add dropTable purge option to Catalog API

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #350: Add dropTable purge option to Catalog API
URL: https://github.com/apache/incubator-iceberg/pull/350#discussion_r311708146
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
 ##########
 @@ -120,6 +120,14 @@ default boolean tableExists(TableIdentifier identifier) {
    */
   boolean dropTable(TableIdentifier identifier);
 
+  /**
+   * Drop a table and remove all data and metadata files.
+   *
+   * @param identifier a table identifier
+   * @return true if the table was dropped, false if the table did not exist
+   */
+  boolean dropTableAndData(TableIdentifier identifier);
 
 Review comment:
   Okay, I've updated this. The new behavior is to drop all table data in `dropTable`, which is documented in javadoc. I've also added a variant of `dropTable` with a `purge` flag that specifies whether to delete data files or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org