You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/06 09:23:04 UTC

[GitHub] [iotdb] wangchao316 commented on a diff in pull request #7231: [IOTDB-4327] Make buffer size configurable

wangchao316 commented on code in PR #7231:
URL: https://github.com/apache/iotdb/pull/7231#discussion_r963473975


##########
consensus/src/main/java/org/apache/iotdb/consensus/config/RatisConfig.java:
##########
@@ -692,4 +701,63 @@ public Grpc.Builder setLeaderOutstandingAppendsMax(int leaderOutstandingAppendsM
       }
     }
   }
+
+  public static class LeaderLogAppender {
+    private final SizeInBytes bufferByteLimit;
+    private final SizeInBytes snapshotChunkSizeMax;
+    private final boolean installSnapshotEnabled;
+
+    private LeaderLogAppender(
+        SizeInBytes bufferByteLimit,
+        SizeInBytes snapshotChunkSizeMax,

Review Comment:
   add parameter in properties?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org