You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by cp...@apache.org on 2020/06/26 17:40:24 UTC
[lucene-solr] branch master updated: SOLR-14376: remove
no-longer-needed 'not no filter queries' check in SolrFeatureWeight
This is an automated email from the ASF dual-hosted git repository.
cpoerschke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
The following commit(s) were added to refs/heads/master by this push:
new 68a9e8f SOLR-14376: remove no-longer-needed 'not no filter queries' check in SolrFeatureWeight
68a9e8f is described below
commit 68a9e8fc97b6268a4ce045fb06438591743d3635
Author: Christine Poerschke <cp...@apache.org>
AuthorDate: Fri Jun 26 17:42:56 2020 +0100
SOLR-14376: remove no-longer-needed 'not no filter queries' check in SolrFeatureWeight
---
.../ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java b/solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java
index 3d32f37..c46a84c 100644
--- a/solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java
+++ b/solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java
@@ -173,11 +173,9 @@ public class SolrFeature extends Feature {
}
}
- if (filterQueries.isEmpty() == false) { // TODO optimize getDocSet to make this check unnecessary SOLR-14376
- DocSet filtersDocSet = searcher.getDocSet(filterQueries); // execute
- if (filtersDocSet != searcher.getLiveDocSet()) {
- filterDocSetQuery = filtersDocSet.getTopFilter();
- }
+ DocSet filtersDocSet = searcher.getDocSet(filterQueries); // execute
+ if (filtersDocSet != searcher.getLiveDocSet()) {
+ filterDocSetQuery = filtersDocSet.getTopFilter();
}
}