[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #83: chore: api server module

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #83:
URL: https://github.com/apache/apisix-ingress-controller/pull/83#discussion_r540850451



##########
File path: pkg/api/server.go
##########
@@ -0,0 +1,64 @@
+//  Licensed to the Apache Software Foundation (ASF) under one or more
+//  contributor license agreements.  See the NOTICE file distributed with
+//  this work for additional information regarding copyright ownership.
+//  The ASF licenses this file to You under the Apache License, Version 2.0
+//  (the "License"); you may not use this file except in compliance with
+//  the License.  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+package api
+
+import (
+	"net"
+
+	"github.com/gin-gonic/gin"
+
+	apirouter "github.com/api7/ingress-controller/pkg/api/router"
+	"github.com/api7/ingress-controller/pkg/config"
+	"github.com/api7/ingress-controller/pkg/log"
+	"github.com/api7/ingress-controller/pkg/types"
+)
+
+// Server represents the API Server in ingress-apisix-controller.
+type Server struct {
+	router       *gin.Engine
+	httpListener net.Listener
+}
+
+// NewServer initializes the API Server.
+func NewServer(cfg *config.Config) (*Server, error) {
+	httpListener, err := net.Listen("tcp", cfg.HTTPListen)
+	if err != nil {
+		return nil, err
+	}
+	gin.SetMode(gin.ReleaseMode)
+	router := gin.New()
+	router.Use(gin.Recovery(), gin.Logger())
+	apirouter.Mount(router)
+
+	return &Server{
+		router:       router,
+		httpListener: httpListener,
+	}, nil
+}
+
+// Run launches the API Server.
+func (srv *Server) Run(stopCh <-chan struct{}) error {
+	go func() {
+		<-stopCh
+		if err := srv.httpListener.Close(); err != nil {
+			log.Errorf("failed to close http listener: %s", err)
+		}
+	}()
+	if err := srv.router.RunListener(srv.httpListener); err != nil && !types.IsUseOfClosedNetConnErr(err) {

Review comment:
       Currently only a health probe, we can add timeout when we have more APIs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org