You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ajantha-bhat (via GitHub)" <gi...@apache.org> on 2023/02/03 07:30:06 UTC
[GitHub] [iceberg] ajantha-bhat opened a new pull request, #6733: Spark-2.4: Handle no-op for rewrite manifests action
ajantha-bhat opened a new pull request, #6733:
URL: https://github.com/apache/iceberg/pull/6733
backport of https://github.com/apache/iceberg/pull/6695
Note that spark-2.4 doesn't have call procedures. Hence, only two file changes.
Also, Added a No-op testcase newly for the spark action itself as there is no procedure to cover that scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #6733: Spark-2.4: Handle no-op for rewrite manifests action
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi merged PR #6733:
URL: https://github.com/apache/iceberg/pull/6733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6733: Spark-2.4: Handle no-op for rewrite manifests action
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #6733:
URL: https://github.com/apache/iceberg/pull/6733#discussion_r1095435003
##########
spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java:
##########
@@ -478,6 +492,33 @@ public void testRewriteManifestsWithPredicate() throws IOException {
Assert.assertEquals("Rows must match", expectedRecords, actualRecords);
}
+ @Test
+ public void testRewriteManifestsNoOp() throws IOException {
Review Comment:
This is an additional test case for the scenario which was covered by spark procedure in 3.1 and above spark versions.
Rest of the changes in the PR is same as #6695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org