You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/01 01:35:41 UTC
[GitHub] [arrow-datafusion] andygrove opened a new issue, #3315: Remove panics from `datafusion-sql` crate
andygrove opened a new issue, #3315:
URL: https://github.com/apache/arrow-datafusion/issues/3315
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
```
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/examples/sql.rs":46 let ast = Parser::parse_sql(&dialect, sql).unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/examples/sql.rs":52 let plan = sql_to_rel.sql_statement_to_plan(statement.clone()).unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/interval.rs":111 calculate_from_part(interval_period_str.unwrap(), unit)?;
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/parser.rs":385 1 => Ok(token.chars().next().unwrap()),
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":99 ScalarValue::Int64(Some(s.parse().unwrap()))
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":257 name: names.get(0).unwrap().to_string(),
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":302 self.statement_to_plan(rewrite.pop_front().unwrap())
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":432 self.statement_to_plan(rewrite.pop_front().unwrap())
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":614 joins.next().unwrap(),
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":884 let mut left = plans.next().unwrap(); // have at least one plan
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":915 .unwrap()
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":925 .unwrap()
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":948 let plan = std::mem::take(&mut remaining_plans[idx]).unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":959 let plan = std::mem::take(&mut remaining_plans[idx]).unwrap();
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":2465 self.statement_to_plan(rewrite.pop_front().unwrap())
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":2503 self.statement_to_plan(rewrite.pop_front().unwrap())
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":2622 && can_hash(left_schema.field_from_column(l).unwrap().data_type())
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":2627 && can_hash(left_schema.field_from_column(r).unwrap().data_type())
"/home/andy/git/apache/arrow-datafusion/datafusion/sql/src/planner.rs":2735 Err(_) => Ok(lit(n.parse::<f64>().unwrap())),
```
**Describe the solution you'd like**
Use `Result` instead
**Describe alternatives you've considered**
None
**Additional context**
Generated by https://github.com/andygrove/no-need-to-panic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on issue #3315: Review use of panic in `datafusion-sql` crate
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on issue #3315:
URL: https://github.com/apache/arrow-datafusion/issues/3315#issuecomment-1240278718
I'd like to pick this to get familiar with the sql code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #3315: Review use of panic in `datafusion-sql` crate
Posted by GitBox <gi...@apache.org>.
alamb closed issue #3315: Review use of panic in `datafusion-sql` crate
URL: https://github.com/apache/arrow-datafusion/issues/3315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org