[GitHub] [spark] cloud-fan commented on a diff in pull request #40194: [SPARK-42602][CORE] Add reason argument to TaskScheduler.cancelTasks

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #40194:
URL: https://github.com/apache/spark/pull/40194#discussion_r1119498853


##########
core/src/main/scala/org/apache/spark/scheduler/TaskScheduler.scala:
##########
@@ -56,7 +56,7 @@ private[spark] trait TaskScheduler {
 
   // Kill all the tasks in a stage and fail the stage and all the jobs that depend on the stage.
   // Throw UnsupportedOperationException if the backend doesn't support kill tasks.
-  def cancelTasks(stageId: Int, interruptThread: Boolean): Unit
+  def cancelTasks(stageId: Int, interruptThread: Boolean, reason: String): Unit

Review Comment:
   if there is always a reason, I think no `Option` is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org