[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

["Karthik Kambatla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456302#comment-15456302 ] 

Karthik Kambatla commented on YARN-5549:
----------------------------------------

The patch looks good, except for the following nits:
# The static imports make sense, but the rest of the code doesn't do it. Can we leave out. If we choose to keep it, when logging "REDACTED etc."
# Some of the changes are unrelated to the patch. To minimize conflicts, I would like for us to leave these out. 

> AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5549
>                 URL: https://issues.apache.org/jira/browse/YARN-5549
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.7.2
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>            Priority: Critical
>         Attachments: YARN-5549.001.patch, YARN-5549.002.patch, YARN-5549.003.patch, YARN-5549.004.patch, YARN-5549.005.patch
>
>
> The command could contain sensitive information, such as keystore passwords or AWS credentials or other.  Instead of logging it as INFO, we should log it as DEBUG and include a property to disable logging it at all.  Logging it to a different logger would also be viable and may create a smaller administrative footprint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org