[GitHub] flink pull request #6165: [FLINK-9577] Divide-by-zero in PageRank

[yanghua <gi...@git.apache.org>]

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/6165

    [FLINK-9577] Divide-by-zero in PageRank

    ## What is the purpose of the change
    
    *This pull request fixed a divide-by-zero error in PageRank*
    
    ## Brief change log
    
      - *Add a judgement to avoid divide-by-zero error*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-9577

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6165.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6165
    
----
commit cb790b3d6e581f64cb033914368424f7feb008b0
Author: yanghua <ya...@...>
Date:   2018-06-14T07:45:52Z

    [FLINK-9577] Divide-by-zero in PageRank

----


---

[GitHub] flink issue #6165: [FLINK-9577] Divide-by-zero in PageRank

[yanghua <gi...@git.apache.org>]

Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/6165
  
    @zentol the field `vertexCount` and `uniformlyDistributedScore` been initialized in open function. if `vertexCount` was set to default value (0). I think `uniformlyDistributedScore` keeps default value is OK, otherwise it would throw an error. if `vertexCount` is not zero, the `uniformlyDistributedScore` would be calculated accurately.


---

[GitHub] flink issue #6165: [FLINK-9577] Divide-by-zero in PageRank

[zentol <gi...@git.apache.org>]

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/6165
  
    How have you verified that this does not affect the semantics of the algorithm?


---