You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/03 10:35:59 UTC

[GitHub] [arrow] alamb commented on pull request #8331: ARROW-10162: [Rust] Add pretty print support for DictionaryArray

alamb commented on pull request #8331:
URL: https://github.com/apache/arrow/pull/8331#issuecomment-703082988


   @jhorstmann  
   
   > Changes look good to me, but I'm wondering now how the existing code handles null values in the primitive arrays. Seems to me that would print the default value. For Utf8 I think it works kinda implicitly because of how the offsets for null values are layed out.
   
   Yes you are correct (that the behavior is incorrect). Good point. I opened  https://issues.apache.org/jira/browse/ARROW-10169 and will fix it in a subsequent PR. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org