[GitHub] [pulsar-client-node] massakam commented on a change in pull request #47: added note for pulsar-client-dev rather than pulsar-client

[GitBox <gi...@apache.org>]

massakam commented on a change in pull request #47: added note for pulsar-client-dev rather than pulsar-client
URL: https://github.com/apache/pulsar-client-node/pull/47#discussion_r316099286
 
 

 ##########
 File path: README.md
 ##########
 @@ -35,6 +35,8 @@ Pulsar Node.js client library is based on the C++ client library. Follow the ins
 [Deb](https://pulsar.apache.org/docs/en/client-libraries-cpp/#deb) or
 [Homebrew packages](https://pulsar.apache.org/docs/en/client-libraries-cpp/#macos).
 
+(Note: you will need to install the pulsar-client-dev library, not the pulsar-client library.)
 
 Review comment:
   Since pulsar-client-dev depends on pulsar-client, users will need to install both packages. So, I think it is better to add the following note:
   
   > Note: you will need to install not only the pulsar-client library but also the pulsar-client-dev library

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services