You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Kevan Miller (JIRA)" <ji...@apache.org> on 2008/12/16 02:19:44 UTC
[jira] Created: (GERONIMO-4470) non-overridable filters working
properly
non-overridable filters working properly
----------------------------------------
Key: GERONIMO-4470
URL: https://issues.apache.org/jira/browse/GERONIMO-4470
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Affects Versions: 2.0.4, 2.1.4, 2.2
Reporter: Kevan Miller
Fix For: 2.2
If we're unable to load a non-overridable class from a parent classloader and inverse classloading is configured, looks like we'll try to load the class from the local ClassLoader. I don't think this is correct. If we're unable to load from a parent classloader, should always return a ClassNotFoundException...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4470) non-overridable filters working
properly
Posted by "Kevan Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656865#action_12656865 ]
Kevan Miller commented on GERONIMO-4470:
----------------------------------------
I noticed the behavior while looking at the code. It seemed inconsistent to me. So, created a Jira to track.
for <hidden-classes> <filter>foo</filter></hidden-classes>, we will *never* search a parent for a foo.* classes.
for <non-overridable> <filter>bar</filter></non-overridable>, we won't load a bar.* classes, if we find the class in a parent. However, if we don't find a bar.LocalOnly in a parent, we'll also try to load from the local ClassLoader. This seems inconsistent to me. And as you note, it's unlikely to behave properly... I would expect the local ClassLoader to never be searched, in this case.
Prolly a relatively minor issue. We can argue semantics... Perhaps you have an argument for why the current behavior is a good thing?
> non-overridable filters working properly
> ----------------------------------------
>
> Key: GERONIMO-4470
> URL: https://issues.apache.org/jira/browse/GERONIMO-4470
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.0.4, 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.2
>
>
> If we're unable to load a non-overridable class from a parent classloader and inverse classloading is configured, looks like we'll try to load the class from the local ClassLoader. I don't think this is correct. If we're unable to load from a parent classloader, should always return a ClassNotFoundException...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4470) non-overridable filters working
properly
Posted by "Kevan Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevan Miller closed GERONIMO-4470.
----------------------------------
Resolution: Won't Fix
This is a minor issue at best. Unless we have stronger motivation, let's close it.
> non-overridable filters working properly
> ----------------------------------------
>
> Key: GERONIMO-4470
> URL: https://issues.apache.org/jira/browse/GERONIMO-4470
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.0.3, 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.2
>
>
> If we're unable to load a non-overridable class from a parent classloader and inverse classloading is configured, looks like we'll try to load the class from the local ClassLoader. I don't think this is correct. If we're unable to load from a parent classloader, should always return a ClassNotFoundException...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4470) non-overridable filters working
properly
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656850#action_12656850 ]
David Jencks commented on GERONIMO-4470:
----------------------------------------
I don't see why you think this is a problem. We aren't overriding a definition from a parent classloader, right?
With typical use of filters org.foo.package.name. it will be hard to make it so org.foo.package.name.ParentClass is correctly loaded from the parent but a org.foo.package.name.subpackage.ChildClassOnlyInLocalClassloader can be loaded at all. Is this causing any actual problems?
> non-overridable filters working properly
> ----------------------------------------
>
> Key: GERONIMO-4470
> URL: https://issues.apache.org/jira/browse/GERONIMO-4470
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.0.4, 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.2
>
>
> If we're unable to load a non-overridable class from a parent classloader and inverse classloading is configured, looks like we'll try to load the class from the local ClassLoader. I don't think this is correct. If we're unable to load from a parent classloader, should always return a ClassNotFoundException...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4470) non-overridable filters working
properly
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Gawor updated GERONIMO-4470:
----------------------------------
Affects Version/s: (was: 2.0.4)
2.0.3
> non-overridable filters working properly
> ----------------------------------------
>
> Key: GERONIMO-4470
> URL: https://issues.apache.org/jira/browse/GERONIMO-4470
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.0.3, 2.1.4, 2.2
> Reporter: Kevan Miller
> Fix For: 2.2
>
>
> If we're unable to load a non-overridable class from a parent classloader and inverse classloading is configured, looks like we'll try to load the class from the local ClassLoader. I don't think this is correct. If we're unable to load from a parent classloader, should always return a ClassNotFoundException...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.