You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/01/25 11:18:23 UTC
[GitHub] [incubator-dubbo] codecov-io commented on issue #3341: Start to use IdleStateHandler in Netty4

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3341?src=pr&el=h1) Report
> Merging [#3341](https://codecov.io/gh/apache/incubator-dubbo/pull/3341?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e3aac2dd2ab9f09d2a27fdf9f2e6cccb1a34bf7f?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `73.07%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3341?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3341      +/-   ##
============================================
+ Coverage     63.67%   63.81%   +0.14%     
+ Complexity       75       71       -4     
============================================
  Files           661      661              
  Lines         28595    28618      +23     
  Branches       4802     4822      +20     
============================================
+ Hits          18209    18264      +55     
+ Misses         8165     8140      -25     
+ Partials       2221     2214       -7
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3341?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `72.5% <0%> (-1.03%)` | `0 <0> (ø)` | |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `70.37% <0%> (-8.7%)` | `0 <0> (ø)` | |
| [...e/dubbo/remoting/transport/netty4/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVyLmphdmE=) | `76.19% <100%> (+4.05%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50LmphdmE=) | `74.19% <100%> (-0.39%)` | `0 <0> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDbGllbnQuamF2YQ==) | `70.89% <50%> (+4.74%)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/common/utils/UrlUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvVXJsVXRpbHMuamF2YQ==) | `78.73% <71.42%> (-0.57%)` | `0 <0> (ø)` | |
| [...ng/exchange/support/header/ReconnectTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9SZWNvbm5lY3RUaW1lclRhc2suamF2YQ==) | `77.27% <85.71%> (+2.27%)` | `0 <0> (ø)` | :arrow_down: |
| [.../exchange/support/header/HeaderExchangeClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUNsaWVudC5qYXZh) | `86.9% <90%> (+2.28%)` | `0 <0> (ø)` | :arrow_down: |
| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `71.29% <94.73%> (+10.03%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNsaWVudC5qYXZh) | `58.46% <0%> (-7.17%)` | `0% <0%> (ø)` | |
| ... and [43 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3341/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3341?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3341?src=pr&el=footer). Last update [e3aac2d...a7b5789](https://codecov.io/gh/apache/incubator-dubbo/pull/3341?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3341 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org