You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2023/07/09 01:49:31 UTC
[GitHub] [trafficserver] bneradt commented on a diff in pull request #9975: Clean up certifier plugin debug messages.
bneradt commented on code in PR #9975:
URL: https://github.com/apache/trafficserver/pull/9975#discussion_r1257396130
##########
plugins/certifier/certifier.cc:
##########
@@ -211,7 +211,7 @@ class SslLRUList
// Remove oldest node if size exceeds limit
if (++size > limit) {
- TSDebug(PLUGIN_NAME, "Removing %s", tail->commonName.c_str());
+ TSDebug(PLUGIN_NAME, "%s: removing '%s'", __func__, tail->commonName.c_str());
Review Comment:
Let's definitely remove explicit function names, but I don't think we need to add them to the log via `__func__` either since we support automatically adding them:
https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.yaml.en.html#proxy-config-diags-show-location
Or does that not apply to plugin messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org