You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/11/16 00:49:02 UTC
[PR] Limit botocore in upgrade tests temporarily [airflow]
potiuk opened a new pull request, #35671:
URL: https://github.com/apache/airflow/pull/35671
Mote does not handle some compressed models in botocore 1.32.1, and it fails our "latest botocore" tests. Moto should be released with a fix to handle compressed versions but until that we limit botocore and boto3 when upgrading then. This limit should be removed as soon as https://github.com/getmoto/moto/issues/7031 is fixed and moto with the fixes is releasedi
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit botocore in upgrade tests temporarily [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #35671: Limit botocore in upgrade tests temporarily
URL: https://github.com/apache/airflow/pull/35671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit botocore in upgrade tests temporarily [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #35671:
URL: https://github.com/apache/airflow/pull/35671#discussion_r1395451617
##########
Dockerfile.ci:
##########
@@ -1045,6 +1045,9 @@ if [[ ${UPGRADE_BOTO=} == "true" ]]; then
echo "${COLOR_BLUE}Upgrading boto3, botocore to latest version to run Amazon tests with them${COLOR_RESET}"
echo
pip uninstall --root-user-action ignore aiobotocore s3fs -y || true
+ # The limits for boto3 and botocore are set only because moto does not handle some changes implemented in botocore 1.31.1
Review Comment:
Right ... Late in the night it was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit botocore in upgrade tests temporarily [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #35671:
URL: https://github.com/apache/airflow/pull/35671#discussion_r1395240639
##########
Dockerfile.ci:
##########
@@ -1045,6 +1045,9 @@ if [[ ${UPGRADE_BOTO=} == "true" ]]; then
echo "${COLOR_BLUE}Upgrading boto3, botocore to latest version to run Amazon tests with them${COLOR_RESET}"
echo
pip uninstall --root-user-action ignore aiobotocore s3fs -y || true
+ # The limits for boto3 and botocore are set only because moto does not handle some changes implemented in botocore 1.31.1
Review Comment:
```suggestion
# The limits for boto3 and botocore are set only because moto does not handle some changes implemented in botocore 1.32.1
```
Same for below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit botocore in upgrade tests temporarily [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #35671:
URL: https://github.com/apache/airflow/pull/35671#discussion_r1395439593
##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -345,6 +345,9 @@ if [[ ${UPGRADE_BOTO=} == "true" ]]; then
echo "${COLOR_BLUE}Upgrading boto3, botocore to latest version to run Amazon tests with them${COLOR_RESET}"
echo
pip uninstall --root-user-action ignore aiobotocore s3fs -y || true
+ # The limits for boto3 and botocore are set only because moto does not handle some changes implemented in botocore 1.31.1
+ # They should be removed as soon as https://github.com/getmoto/moto/issues/7031 is fixed and moto with the fixes is released
+ pip install --root-user-action ignore --upgrade "boto3<1.29.1" "botocore<1.32.1"
pip install --root-user-action ignore --upgrade boto3 botocore
Review Comment:
Yes. It was late in the night :facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit botocore in upgrade tests temporarily [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35671:
URL: https://github.com/apache/airflow/pull/35671#issuecomment-1814470108
Closing as moto 4.2.9 has been released with fix. The "Latest Boto" job should get green automatically with next main build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit botocore in upgrade tests temporarily [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35671:
URL: https://github.com/apache/airflow/pull/35671#issuecomment-1814153000
OK. Seems that the fix is coming in moto 4.2.9 - so we should likely just wait https://github.com/getmoto/moto/issues/7031#issuecomment-1814142971
Convert it to Draft for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Limit botocore in upgrade tests temporarily [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #35671:
URL: https://github.com/apache/airflow/pull/35671#discussion_r1395156553
##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -345,6 +345,9 @@ if [[ ${UPGRADE_BOTO=} == "true" ]]; then
echo "${COLOR_BLUE}Upgrading boto3, botocore to latest version to run Amazon tests with them${COLOR_RESET}"
echo
pip uninstall --root-user-action ignore aiobotocore s3fs -y || true
+ # The limits for boto3 and botocore are set only because moto does not handle some changes implemented in botocore 1.31.1
+ # They should be removed as soon as https://github.com/getmoto/moto/issues/7031 is fixed and moto with the fixes is released
+ pip install --root-user-action ignore --upgrade "boto3<1.29.1" "botocore<1.32.1"
pip install --root-user-action ignore --upgrade boto3 botocore
Review Comment:
Should this line be commented out or delted? Otherwise this will upgrade both packages to latest versions and break the previous line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org