You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "David J. M. Karlsen (JIRA)" <ji...@codehaus.org> on 2010/01/21 15:39:55 UTC

[jira] Created: (MNG-4540) False positives on ${version} usage

False positives on ${version} usage
-----------------------------------

                 Key: MNG-4540
                 URL: http://jira.codehaus.org/browse/MNG-4540
             Project: Maven 2 & 3
          Issue Type: Bug
          Components: Design, Patterns & Best Practices
    Affects Versions: 3.0-alpha-5
            Reporter: David J. M. Karlsen


I get this warning with mvn 3 alpha5:
[WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. @ com.davidkarlsen.zipcodeservice:zipcodeservice-selenium-tests:1.0-SNAPSHOT, /u/david/projects/davidkarlsen.com/zipcodeservice/zipcodeservice-selenium-tests/pom.xml

but this is not the case, the pom's contain cxf.version, not version:
:~/projects/davidkarlsen.com/zipcodeservice$ find . -name pom.xml -exec fgrep -il '${version}' '{}' \;
:~/projects/davidkarlsen.com/zipcodeservice$ find . -name pom.xml -exec fgrep -il '${cxf.version}' '{}' \;
./zipcodeservice-core/pom.xml



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-4540) False positives on ${version} usage

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann updated MNG-4540:
-----------------------------------

    Attachment: pom.xml

Working example POM.

> False positives on ${version} usage
> -----------------------------------
>
>                 Key: MNG-4540
>                 URL: http://jira.codehaus.org/browse/MNG-4540
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Design, Patterns & Best Practices
>    Affects Versions: 3.0-alpha-5
>            Reporter: David J. M. Karlsen
>            Assignee: Benjamin Bentmann
>         Attachments: pom.xml
>
>
> I get this warning with mvn 3 alpha5:
> [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. @ com.davidkarlsen.zipcodeservice:zipcodeservice-selenium-tests:1.0-SNAPSHOT, /u/david/projects/davidkarlsen.com/zipcodeservice/zipcodeservice-selenium-tests/pom.xml
> but this is not the case, the pom's contain cxf.version, not version:
> :~/projects/davidkarlsen.com/zipcodeservice$ find . -name pom.xml -exec fgrep -il '${version}' '{}' \;
> :~/projects/davidkarlsen.com/zipcodeservice$ find . -name pom.xml -exec fgrep -il '${cxf.version}' '{}' \;
> ./zipcodeservice-core/pom.xml

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-4540) False positives on ${version} usage

Posted by "David J. M. Karlsen (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=207754#action_207754 ] 

David J. M. Karlsen commented on MNG-4540:
------------------------------------------

You're right - it got pulled in through another parent pom which hadn't been deployed (updated) yet.
Sorry for the noise.

> False positives on ${version} usage
> -----------------------------------
>
>                 Key: MNG-4540
>                 URL: http://jira.codehaus.org/browse/MNG-4540
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Design, Patterns & Best Practices
>    Affects Versions: 3.0-alpha-5
>            Reporter: David J. M. Karlsen
>            Assignee: Benjamin Bentmann
>         Attachments: pom.xml
>
>
> I get this warning with mvn 3 alpha5:
> [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. @ com.davidkarlsen.zipcodeservice:zipcodeservice-selenium-tests:1.0-SNAPSHOT, /u/david/projects/davidkarlsen.com/zipcodeservice/zipcodeservice-selenium-tests/pom.xml
> but this is not the case, the pom's contain cxf.version, not version:
> :~/projects/davidkarlsen.com/zipcodeservice$ find . -name pom.xml -exec fgrep -il '${version}' '{}' \;
> :~/projects/davidkarlsen.com/zipcodeservice$ find . -name pom.xml -exec fgrep -il '${cxf.version}' '{}' \;
> ./zipcodeservice-core/pom.xml

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-4540) False positives on ${version} usage

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MNG-4540.
----------------------------------

    Resolution: Cannot Reproduce
      Assignee: Benjamin Bentmann

The code only issues this warning when the expression is actually hit so I'm pretty sure this works. There is no demo project to verify your assertion.

More than likely this expression is introduced by some parent POM.

> False positives on ${version} usage
> -----------------------------------
>
>                 Key: MNG-4540
>                 URL: http://jira.codehaus.org/browse/MNG-4540
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Design, Patterns & Best Practices
>    Affects Versions: 3.0-alpha-5
>            Reporter: David J. M. Karlsen
>            Assignee: Benjamin Bentmann
>
> I get this warning with mvn 3 alpha5:
> [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. @ com.davidkarlsen.zipcodeservice:zipcodeservice-selenium-tests:1.0-SNAPSHOT, /u/david/projects/davidkarlsen.com/zipcodeservice/zipcodeservice-selenium-tests/pom.xml
> but this is not the case, the pom's contain cxf.version, not version:
> :~/projects/davidkarlsen.com/zipcodeservice$ find . -name pom.xml -exec fgrep -il '${version}' '{}' \;
> :~/projects/davidkarlsen.com/zipcodeservice$ find . -name pom.xml -exec fgrep -il '${cxf.version}' '{}' \;
> ./zipcodeservice-core/pom.xml

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira