Re: Review Request 71059: Added consumed quota, allocated, reserved, offered to the roles table.

[Mesos Reviewbot <re...@mesos.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71059/#review216535
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71060, 71050, 71051, 71052, 71053, 71059]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 11, 2019, 5:07 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71059/
> -----------------------------------------------------------
> 
> (Updated July 11, 2019, 5:07 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Andrei Sekretenko, and Meng Zhu.
> 
> 
> Bugs: MESOS-8789
>     https://issues.apache.org/jira/browse/MESOS-8789
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds resource breakdowns on a per role basis to the roles table
> in the webui, each column except for the role name is selectable to
> allow the user to tune the view for their needs.
> 
> 
> Diffs
> -----
> 
>   src/webui/app/controllers.js 42a9fb657e98bbd57265f2c9cf8e4d1013d3f271 
>   src/webui/app/roles/roles.html 45e2a332e62e072e97fc97ab3945ff65ad942ddf 
> 
> 
> Diff: https://reviews.apache.org/r/71059/diff/1/
> 
> 
> Testing
> -------
> 
> See attached gif.
> 
> 
> File Attachments
> ----------------
> 
> demo
>   https://reviews.apache.org/media/uploaded/files/2019/07/11/44987278-1415-4e55-a36f-2fb299d930e0__roles-table-selectable-columns2.gif
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>